Hi Alex, very nice! I'm currently "merging" a homegrown checkstyle extension and one provided by Klaas Prause. Unfortunately the merging is right now on hold, as at work there's very much to do. So I plan to continue with this next week, I'll come back to you when I have a checkstyle extension for review/debugging.
Thanx && cheers, Martin On Wed, 2009-07-15 at 17:32 -0700, Alex Boisvert wrote: > I can try to debug this ... > > Which version of the checkstyle extension are you using? (We should > probably add it to the list of plugins too...) > > alex > > On Tue, Jul 14, 2009 at 2:28 PM, Martin Grotzke < > [email protected]> wrote: > > > Great, thanx for the hint! When I remove the checkstyle extension I have > > included the eclipse artifacts are generated correctly - with the > > customized m2 repo var. > > > > Thanx && cheers, > > Martin > > > > > > On Mon, 2009-07-13 at 18:12 -0700, Alex Boisvert wrote: > > > Does the Eclipse task get triggered? Did you try adding a few trace > > > statements to see what gets executed? Do you have any other > > customization > > > in your buildfile? > > > > > > alex > > > > > > On Mon, Jul 13, 2009 at 3:00 PM, Martin Grotzke < > > > [email protected]> wrote: > > > > > > > On Mon, 2009-07-13 at 15:39 -0500, Daniel Spiewak wrote: > > > > > Have you explicitly rm'd your old .classpath and .project files? > > Those > > > > > files are created using Rake FileTask(s), which don't know anything > > about > > > > > changes to eclipse.rb. > > > > Yes, I did that. > > > > > > > > Cheers, > > > > Martin > > > > > > > > > > > > > > Daniel > > > > > > > > > > On Mon, Jul 13, 2009 at 3:37 PM, Martin Grotzke < > > > > > [email protected]> wrote: > > > > > > > > > > > Hi Alex, > > > > > > > > > > > > great, thanx a lot! > > > > > > > > > > > > I copied the changed eclipse.rb from svn to the installed one, > > > > > > unfortunately now a buildr eclipse does not create eclipse > > artifacts > > > > > > anymore (this is the same behaviour I already discovered > > previously). > > > > > > When I restore the former version of eclipse.rb eclipse artifacts > > are > > > > > > created as expected again. > > > > > > > > > > > > Do you have a clue what might be wrong? > > > > > > > > > > > > Cheers, > > > > > > Martin > > > > > > > > > > > > > > > > > > On Fri, 2009-07-10 at 12:24 -0700, Alex Boisvert wrote: > > > > > > > Done. > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/BUILDR-295 > > > > > > > > > > > > > > > > > > > > > On Thu, Jul 9, 2009 at 2:42 PM, Martin Grotzke < > > > > > > [email protected] > > > > > > > > wrote: > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > below were my questions on the provided examples - to make it > > > > short: I > > > > > > > > didn't get it to work. Can you help a little more, please? > > > > > > > > > > > > > > > > Thanx && cheers, > > > > > > > > Martin > > > > > > > > > > > > > > > > > > > > > > > > On Wed, 2009-07-08 at 09:35 +0200, Martin Grotzke wrote: > > > > > > > > > On Tue, 2009-07-07 at 19:12 -0700, Alex Boisvert wrote: > > > > > > > > > > On Tue, Jul 7, 2009 at 3:11 PM, Martin Grotzke < > > > > > > > > [email protected] > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Thanx for the hint! It works, but to me it does not seem > > like > > > > a > > > > > > clean > > > > > > > > > > > solution but rather like a workaround. For one thing my > > > > collegues > > > > > > > > would > > > > > > > > > > > think that buildr needs hacks for such things, on the > > other > > > > hand > > > > > > I'd > > > > > > > > > > > like to learn how to do this the "right" way :) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Another approach would be to mimic an existing idiom, e.g., > > > > > > > > > > > > > > > > > > > > compile.options.source = "1.5" > > > > > > > > > > > > > > > > > > > > using the following rough structure, > > > > > > > > > > > > > > > > > > > > module Buildr > > > > > > > > > > module Eclipse > > > > > > > > > > def eclipse > > > > > > > > > > @eclipse || Eclipse.new > > > > > > > > > > end > > > > > > > > > > > > > > > > > > > > class Eclipse > > > > > > > > > > attr_reader :options > > > > > > > > > > > > > > > > > > > > def initialize > > > > > > > > > > @options = Options.new > > > > > > > > > > end > > > > > > > > > > end > > > > > > > > > > > > > > > > > > > > class Options > > > > > > > > > > attr_accessor :m2_repo_var > > > > > > > > > > > > > > > > > > > > def initialize > > > > > > > > > > @m2_repo_var = 'M2_REPO' > > > > > > > > > > end > > > > > > > > > > end > > > > > > > > > Ok, I added this. > > > > > > > > > > > > > > > > > > > end > > > > > > > > > > > > > > > > > > > > # existing code elided > > > > > > > > > > > > > > > > > > > > include Eclipse > > > > > > > > > The include Eclipse shall go into the same file and belongs > > to > > > > the > > > > > > > > > "module Buildr"? The end of my eclipse.rb then looks like > > this: > > > > > > > > > > > > > > > > > > --------------------- > > > > > > > > > end > > > > > > > > > > > > > > > > > > include Eclipse > > > > > > > > > > > > > > > > > > end # module Buildr > > > > > > > > > > > > > > > > > > > > > > > > > > > class Buildr::Project > > > > > > > > > include Buildr::Eclipse > > > > > > > > > end > > > > > > > > > --------------------- > > > > > > > > > > > > > > > > > > > end > > > > > > > > > > > > > > > > > > I changed writing the classpath entry from > > > > > > > > > classpathentry.var m2_libs, 'M2_REPO', m2repo > > > > > > > > > to > > > > > > > > > classpathentry.var m2_libs, > > > > project.eclipse.options.m2_repo_var, > > > > > > m2repo > > > > > > > > > > > > > > > > > > However, now buildr eclipse no longer creates eclipse > > artifacts. > > > > > > > > > > > > > > > > > > Probably s.th. is wrong here? > > > > > > > > > > > > > > > > > > Thanx for your help, > > > > > > > > > cheers, > > > > > > > > > Martin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > which would lead to this in your buildfile: > > > > > > > > > > > > > > > > > > > > eclipse.options.m2_repo_var = 'PROJ_REPO' > > > > > > > > > > > > > > > > > > > > alex > > > > > > > > > > > > > > > > > > > >
signature.asc
Description: This is a digitally signed message part
