On 05/05/2015 07:24 PM, Roland Haas wrote: > Hello Bruno, Frank, > >> On Tue, May 05, 2015 at 11:55:16AM -0500, Frank Loeffler wrote: >>> Doesn't this patch always set BOOST_*_DIRS to some multi-arch >>> directory (if gcc is found), even if it was installed in a >>> standard location (/usr or /usr/local)? Shouldn't it only set >>> these if a multi-arch directory is actually found? >> >> The same would apply also to the changes to other libraries. Not >> everyone who uses gcc is on a multi-arch setup. > I think the ticket https://trac.einsteintoolkit.org/ticket/1769 > actually says that "that MACHINE needs to also be taken into > account in the actual search phase earlier on in detect.sh when > libdir is set." So I would treat this as work in progress and > request further changes, best to first implement all required > changes in say HDF5 then replicate to the other libraries. Please > note that at least the change to HDF5 (which is quite different > from the change in Boost) just adds extra libdirs and incdirs which > is "safe". > yes, this is a work in progress. I did a minimal patch to make it work for ubuntu. I agree with you both that this change should go earlier on the search phase, but that would require more changes and tests than I wanted to include in the release. Besides each external library have very handcrafted scripts. A general solution might not apply over the board easily.
Cheers, Bruno. > Yours, Roland > > > > _______________________________________________ Users mailing list > [email protected] http://cactuscode.org/mailman/listinfo/users > _______________________________________________ Users mailing list [email protected] http://cactuscode.org/mailman/listinfo/users
