Hello Erik, all, > You suggest adding -D... flags to CFLAGS. However, we distinguish between > CPPFLAGS and CFLAGS in Cactus. Why not add the option to CPPFLAGS? I guess CPPFLAGS would also work. I kind of disliked using CPPFLAGS since the issue is not with the preprocessor but really with the compiler (being more akin to choosing a language standard than say specifying where to find include files).
To tell the truth, I had not actually noticed that you had changed configure from CFLAGS/CXXFLAGS to CPPFLAGS (since the commit message gave no indication that anything other than "Disable strdup prototype checks" was done :-) ) and I had assumed that I myself had used CPPFLAGS accidentally before. Either way is fine with me though, given that we do always use both CFLAGS+CPPFLAGS and CXXFLAGS+CPPFLAGS when compiling code and that apparently (I had not known) even C++ does not provide M_PI by default. Please feel free to just git revert the last commit. Yours, Roland -- My email is as private as my paper mail. I therefore support encrypting and signing email messages. Get my PGP key from http://keys.gnupg.net.
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ Users mailing list [email protected] http://cactuscode.org/mailman/listinfo/users
