Tried building it earlier on before I sent the mail - but it failed on some missing jboss component (built the whole tree). Anyways - working fine with 2.14.1-SNAPSHOT! Thanks!
2014-09-28 21:10 GMT+02:00 Babak Vahdat <[email protected]>: > Ah but much easier is to build the master branch on your box locally using > the latest codebase (however without running the tests which would not take > more than couple of minutes) so that your m2-cache for the 2.15-SNAPSHOT > version is up-to-date. Then you could run/test your app using your locally > installed Camel bundles version 2.15-SNAPSHOT. > > That all said I forced a build on the CI-Server: > https://builds.apache.org/job/Camel.trunk.notest/2177 > > Which updated the artifacts of the Apache snapshot repo right before, e.g. > the camel-core bundle below: > > http://repository.apache.org/content/repositories/snapshots/org/apache/camel/camel-core/2.15-SNAPSHOT/camel-core-2.15-20140928.184831-29.jar > > So maybe make sure to include the Apache snapshot repo inside your (parent) > POM: > http://camel.apache.org/maven-2-snapshot-repository-in-pom.html > > And now using the Maven "-U" option run/test your app again. > > Babak > > David J. M. Karlsen wrote > > Did not work with latest published snapshots - but perhaps a successful > > build&deploy has not yet completed? > > > > 2014-09-27 22:40 GMT+02:00 Babak Vahdat < > > > babak.vahdat@ > > > >: > > > >> Thanks for raising the ticket which is fixed now, both on the master as > >> well > >> as the 2.14.x branch. Would you mind to give it a shot to see if it > works > >> for you now? > >> > >> I also raised another ticket regarding my previous comment about the > >> possible improvement > >> https://issues.apache.org/jira/browse/CAMEL-7877 > >> > >> Babak > >> > >> David J. M. Karlsen wrote > >> > Created https://issues.apache.org/jira/browse/CAMEL-7874 > >> > > >> > > >> > 2014-09-27 17:13 GMT+02:00 Babak Vahdat < > >> > >> > babak.vahdat@ > >> > >> > >: > >> > > >> >> Hi, > >> >> > >> >> I looked a bit into the codebase regarding this and spotted some > space > >> >> for > >> >> improvement: > >> >> > >> >> - First of all there's a copy/paste typo at the following line > (pasted > >> >> from > >> >> the previous code block): > >> >> > >> >> > >> >> > >> > https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/model/dataformat/JsonDataFormat.java#L175 > >> >> > >> >> As it tries to set the the unmarshalType object value for the > >> prettyPrint > >> >> property, which is wrong. > >> >> > >> >> - Secondly with the current codebase it's *only* the > JacksonDataFormat > >> >> which > >> >> *truly* supports the prettyPrint option: > >> >> > >> >> > >> >> > >> > https://github.com/apache/camel/blob/master/components/camel-jackson/src/main/java/org/apache/camel/component/jackson/JacksonDataFormat.java#L46 > >> >> > >> >> And *all* the other formats fail to do so (including the default > >> XStream > >> >> format), as they don't own any prettyPrint property! The last Gson > >> format > >> >> below has a wrong naming: 'prettyPrinting' instead of 'prettyPrint'. > >> >> > >> >> > >> >> > >> > https://github.com/apache/camel/blob/master/components/camel-xstream/src/main/java/org/apache/camel/dataformat/xstream/XStreamDataFormat.java > >> >> > >> >> > >> >> > >> > https://github.com/apache/camel/blob/master/components/camel-xstream/src/main/java/org/apache/camel/dataformat/xstream/JsonDataFormat.java > >> >> > >> >> > >> >> > >> > https://github.com/apache/camel/blob/master/components/camel-gson/src/main/java/org/apache/camel/component/gson/GsonDataFormat.java > >> >> > >> >> Last but not least, we should better not ignore the case if no setter > >> >> method > >> >> is found below (IntrospectionSupport#setProperty would return false > in > >> >> such > >> >> a case) > >> >> > >> >> > >> >> > >> > https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/model/DataFormatDefinition.java#L148 > >> >> > >> >> > >> > https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/model/DataFormatDefinition.java#L150 > >> >> > >> >> As otherwise we don't know if a given data format *truly* supports a > >> >> given > >> >> option called x. Currently we would ignore the case if there’s no > >> setX() > >> >> setter method on a given dataformat object. > >> >> > >> >> I guess the current workaround for you is to make use of Jackson: > >> >> > >> >> > >> > > > <json library="Jackson" prettyPrint="true" .../> > >> >> > >> >> Would you mind to raise a ticket? > >> >> > >> >> Babak > >> >> > >> >> David J. M. Karlsen wrote > >> >> > With the config: > >> >> > > >> > > > <camel:unmarshal> > >> >> > > >> >> > > >> > > > <camel:json prettyPrint="true" library="Jackson" /> > >> >> > > >> >> > > >> > > > </camel:unmarshal> > >> >> > I get: > >> >> > > >> >> > .. because of Failed to set property: prettyPrint on: > >> >> > org.apache.camel.component.jackson.JacksonDataFormat@77ab22be. > >> Reason: > >> >> > java.lang.IllegalArgumentException: Could not find a suitable > setter > >> >> for > >> >> > property: prettyPrint as there isn't a setter method with same > type: > >> >> > [null] > >> >> > nor type conversion possible: null > >> >> > > >> >> > at > >> >> > > >> >> > >> > org.apache.camel.util.ObjectHelper.wrapRuntimeCamelException(ObjectHelper.java:1364) > >> >> > > >> >> > at > >> >> > > >> >> > >> > org.apache.camel.spring.SpringCamelContext.onApplicationEvent(SpringCamelContext.java:122) > >> >> > > >> >> > at > >> >> > > >> >> > >> > org.apache.camel.spring.CamelContextFactoryBean.onApplicationEvent(CamelContextFactoryBean.java:327) > >> >> > > >> >> > at > >> >> > > >> >> > >> > org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:151) > >> >> > > >> >> > at > >> >> > > >> >> > >> > org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:128) > >> >> > > >> >> > at > >> >> > > >> >> > >> > org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:331) > >> >> > > >> >> > at > >> >> > > >> >> > >> > org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:773) > >> >> > > >> >> > at > >> >> > > >> >> > >> > org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:483) > >> >> > > >> >> > at > >> >> > > >> >> > >> > org.springframework.test.context.support.AbstractGenericContextLoader.loadContext(AbstractGenericContextLoader.java:125) > >> >> > > >> >> > at > >> >> > > >> >> > >> > org.springframework.test.context.support.AbstractGenericContextLoader.loadContext(AbstractGenericContextLoader.java:60) > >> >> > after this upgrade: > >> >> > > >> >> > - > >> >> > > >> > > > <camel.version> > >> >> > 2.13.2 > >> >> > > >> > > > </camel.version> > >> >> > + > >> >> > > >> > > > <camel.version> > >> >> > 2.14.0 > >> >> > > >> > > > </camel.version> > >> >> > > >> >> > jira https://issues.apache.org/jira/browse/CAMEL-7639 says it was > >> fixed > >> >> > for > >> >> > 2.14.0 - but it actually worked before on 2.13.2? > >> >> > -- > >> >> > -- > >> >> > David J. M. Karlsen - http://www.linkedin.com/in/davidkarlsen > >> >> > >> >> > >> >> > >> >> > >> >> > >> >> -- > >> >> View this message in context: > >> >> > >> > http://camel.465427.n5.nabble.com/Problems-prettyPrinting-JSON-after-camel-2-14-0-upgrade-tp5756738p5757104.html > >> >> Sent from the Camel - Users mailing list archive at Nabble.com. > >> >> > >> > > >> > > >> > > >> > -- > >> > -- > >> > David J. M. Karlsen - http://www.linkedin.com/in/davidkarlsen > >> > >> > >> > >> > >> > >> -- > >> View this message in context: > >> > http://camel.465427.n5.nabble.com/Problems-prettyPrinting-JSON-after-camel-2-14-0-upgrade-tp5756738p5757111.html > >> Sent from the Camel - Users mailing list archive at Nabble.com. > >> > > > > > > > > -- > > -- > > David J. M. Karlsen - http://www.linkedin.com/in/davidkarlsen > > > > > > -- > View this message in context: > http://camel.465427.n5.nabble.com/Problems-prettyPrinting-JSON-after-camel-2-14-0-upgrade-tp5756738p5757155.html > Sent from the Camel - Users mailing list archive at Nabble.com. > -- -- David J. M. Karlsen - http://www.linkedin.com/in/davidkarlsen
