I agree the change I referenced in TransactionErrorHandler fixes the bug you referenced (CAMEL-8424), but I believe that fix introduces another bug; namely creating two transactions when only one should be created. It is the presence of “PROPAGATION_REQUIRES_NEW” in my route example that makes it a transacted route. In my test, there is no transaction in existence prior to the TransactionErrorHandler coming across the “PROPAGATION_REQUIRES_NEW” tag. Therefore, it should create one new transaction, and process the rest of the route in that transaction. Instead, it creates two.
Furthermore, in another test method we have a route with “PROPAGATION_REQUIRED" that forwards processing to the route in my example. In that case, there should be two transactions created and committed, and instead there are three. One in the initial route, and 2 in the route with “PROPAGATION_REQUIRES_NEW”. I know very little about Camel, but I'm well versed in transaction management with Spring. It doesn't make sense that seeing one “PROPAGATION_REQUIRES_NEW” causes two transactions to be created one right after the other. respectfully, Jim On Thu, Jan 11, 2018 at 2:56 AM, Karel Bernolet <karel.berno...@gmail.com> wrote: > > Hello, > > Can this be a bug fix instead of a bug in the latest versions? > Assuming your route executes in a transactional context, once it hits > “PROPAGATION_REQUIRES_NEW”, a new transaction should always be created, > hence you now have 2 transactions. > At the end of your tests, successful transactions are to be committed, and > your mock is called once for each transaction. > Before camel 2.13.4, there was a bug related to “PROPAGATION_REQUIRES_NEW” > and “direct” endpoints. I believe this bug might have affected “direct-vm” > endpoints too. (see https://issues.apache.org/jira/browse/CAMEL-8424 < > https://issues.apache.org/jira/browse/CAMEL-8424>). > This means that your original test case has been faulty until now. > > mvg, > Karel > > > On 10 Jan 2018, at 22:26, Jim Reitz <jimre...@ieee.org> wrote: > > > > I am in the process of upgrading from Camel 2.12.x to 2.18.x. I have a > > unit test that verifies transacted routes work as expected. The test > used > > to work but after upgrading Camel, it now fails. The failure appears to > be > > related to encountering a route with "PROPAGATION_REQUIRES_NEW". > > > > The test uses a mock platform transaction manager, and it verifies that > > getTransaction() and commit() are only called once on that mock. > However, > > after changing to Camel 2.13.4 or above (have tried the latest point > > release of each major version up to 2.18.3), the test now fails because > > getTransaction() and commit() are called twice on the platform > transaction > > manager mock. In other words, Camel appears to be be creating two > > transactions when it should only be creating one. Note that this > behavior > > is not seen when using PROPAGATION_REQUIRED. > > > > The route in the test looks like this: > > EventDrivenConsumerRoute[direct-vm://rollbackAll.innerRoute -> Channel[ > > TransactionErrorHandler:PROPAGATION_REQUIRES_NEW[ > > Channel[sendTo(mock://result)]]]]> > > > > In addition I see the following two identical log statements from the > > output of the test (including the transactionKey 0x6775c0d1 in parens) > > which seem to reinforce my summation of what's happening: > > 2018-01-10 19:25:36,804 DEBUG [main] > > org.apache.camel.spring.spi.TransactionErrorHandler > > - <Transaction begin (0x6775c0d1) redelivered(unknown) for (MessageId: > > ID-hostname-39408-1515612165923-0-1 on ExchangeId: ID-hostname-39408- > > 1515612165923-0-4))> > > ... > > 2018-01-10 19:25:37,966 DEBUG [main] > > org.apache.camel.spring.spi.TransactionErrorHandler > > - <Transaction begin (0x6775c0d1) redelivered(unknown) for (MessageId: > > ID-hostname-39408-1515612165923-0-1 on ExchangeId: ID-hostname-39408- > > 1515612165923-0-4))> > > > > It is not feasible for me to post the test as it is on an isolated > > machine/system. > > > > When using the debugger in Eclipse to step through the test, I noticed in > > TransactionErrorHandler#process(Exchange) line 98 (Camel version 2.18.3) > > has this line that I believe was modified in version 2.13.4: > > if(transactionTemplate.getPropagationBehavior() != > > TransactionDefinition.PROPAGATION_REQUIRES_NEW > > && exchange.getUnitOfWork().isTransactedBy(transactionKey)) { > > > > I believe the issue is related to the above line. This conditional block > > determines if the code calls processByErrorHandler(Exchange) or > > processInTransaction(Exchange). In the case of the above documented > route, > > processInTransaction(Exchange) is called twice (I believe in error), > > instead of calling processInTransaction(Exchange) first, and then > > subsequently calling processByErrorHandler(Exchange). > > > > If I'm correct, I can see how this bug could be overlooked because > creating > > an extra transaction doesn't really have any bad side effects except for > > overhead/performance. > > > > Thoughts? > >
