GitHub user bradh352 added a comment to the discussion: Host based routing - 
EVPN-VXLAN to the host - Single VXLAN Device (SVD)

wow, that's some awk there.  I see you're using bridge -j, think about using 
'jq' instead?

Anyhow other notes:

- When generating the vlan to vni map, shouldn't you restrict it to only the 
bridge you're interested in?  Couldn't there be other bridges on the system 
that should be ignored?
- If the VNI already exists I see you pretty much just return.  But shouldn't 
you instead extract the VLAN its mapped to and call `bridge vlan add vid 
${Vlan} dev ${VETHPEER}`  ?  I'd think you could have dozens of virtual 
machines on a host attached to the same VNI so that needs to be supported.
- Similar comment on delete, can only delete the VNI/VLAN once the count of 
VETH associated with it hits zero.


GitHub link: 
https://github.com/apache/cloudstack/discussions/10786#discussioncomment-13454142

----
This is an automatically sent email for users@cloudstack.apache.org.
To unsubscribe, please send an email to: users-unsubscr...@cloudstack.apache.org

Reply via email to