GitHub user daviftorres edited a discussion: Improve message "Network is unavailable. Please contact administrator"
Recently I had faced this message when trying to deploy a new instance in a guest network that was already in use. <img width="423" height="176" alt="image" src="https://github.com/user-attachments/assets/86bc6f13-093d-4ca9-bfa6-bee77c7d81fd"; /> I did not realized the VR was running on a version that was prior to the latest (4.20.1) and the Management server was on the latest (4.20.2). I guest there are many ways this exception can be triggered and the message has to be generic enough to point in the right direction and cannot cover all possible cases with unique exceptions. For my surprise, there is `e` in the code but it does not output any thing, so I propose to change to `e.getMessage()`. Maybe even adding a bit more description to the message would be appreciated but not required. https://github.com/apache/cloudstack/blob/15c2e50338a514cb51e6ef3443261a7d3971f69c/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java#L938 See examples/proposals below: <img width="1884" height="318" alt="image" src="https://github.com/user-attachments/assets/a9903c04-d158-454c-81a8-b9812ac50e2e"; /> Or <img width="1469" height="330" alt="image" src="https://github.com/user-attachments/assets/db65250f-ea18-4bfb-b6f8-db8be9068b1b"; /> Just "Network is unavailable" throw me off to network connectivity between Management and Agent or other connectivity issues. When in fact, it the Guest Network and its VR did not pass the criteria to be used. Please share your thoughts and I would be glad to provide a PR for this trivial change. GitHub link: https://github.com/apache/cloudstack/discussions/11980 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
