GitHub user iishitahere added a comment to the discussion: Wrong Traffic Shaping in Secondary NIC over L2 networks
Hi @DaanHoogland , I hope this message finds you well. I apologize for the delay in submitting this fix; I was one day late due to unforeseen circumstances. Thank you for your patience. Regarding the issue, I’ve made the following changes in the VmwareTrafficLabel class to resolve the inconsistent bandwidth allocation for secondary NICs in VMware L2 networks: Traffic Label Parsing Enhancement: Updated the _parseLabel method to ensure consistent interpretation of the traffic label, irrespective of NIC type. Default Values Adjustment: Ensured that both the default NIC and secondary NICs adhere to the same bandwidth specifications derived from the network offering or global throttling settings. Error Handling Improvement: Added checks to validate and handle unexpected or invalid traffic label fields gracefully, reducing potential misconfigurations. Code Cleanup: Simplified logic and ensured compliance with the project's coding standards for better readability and maintainability. These changes aim to align the bandwidth configuration across all NICs of a VM, as per the expected behavior described in the issue report. I have tested the changes locally to verify their correctness. Please let me know if there’s anything else I need to address or refine. I look forward to your feedback and further guidance. Thank you again for your time and support! Best regards, Ishita Jaiswal GitHub link: https://github.com/apache/cloudstack/discussions/12378#discussioncomment-15423409 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
