Hi Travis, Le Sun, 23 Mar 2025 18:23:50 -0700, Travis Bean <tbea...@gmail.com> a écrit :
> I developed a Bash script to automate the installation and > configuration of open-source software (i.e., launchpad.net/linuxha). I > want to make sure the syntax of this script is perfect so I can use it > as a teaching tool to educate people about Linux. > […]when I first got this custom setup successfully working on two virtual > machines, it was really a miracle. > > I haven’t been able to thoroughly test this Bash script out to make > sure it functions as intended for all environments, so I need feedback > to make sure I haven’t overlooked something with my current syntax. I should admit this is a huge amount of work. What a patience, cheers! However, at least in regard with the Pacemaker/Corosync parts, it seems to me you actually wrote in bash what tools like pcs/pcsd or crmsh are already doing quite nicely. But, based on https://code.launchpad.net/linuxha, it seems your script is way older than your email on this list, as I can find reference of old technologies, your "Copyfree 2016" and indeed commits from 2016. I'm not sure when pcs/pcsd appeared… Anyway, nowadays, I would use Ansible and pcs/pcsd to build such clusters. It's easier, faster, safer. If you really want to maintain such a script for some reason, in regard with your bash syntax, maybe you could start feed your script to "shellcheck" first. Then, it all depend on your coding style, the bash-ism you are ready to accept, how strict you want to be, etc… Regards, _______________________________________________ Manage your subscription: https://lists.clusterlabs.org/mailman/listinfo/users ClusterLabs home: https://www.clusterlabs.org/