Unico Hommes dijo:
> Surely you couldn't have missed it. You committed it:
>
> http://cvs.apache.org/viewcvs.cgi/cocoon-2.1/src/java/org/apache/cocoon/generation/JXTemplateGenerator.java?r1=1.46&r2=1.47
>
> Now reviewing the patch, I can't imagine how this is going to work. Both
> cache key and validity objects that are passed in via the context seem
> to be returned without augmenting them. AFAICS they should be combined
> with a key identifying the src of the generator and the validity of that
> src respectively in order to work.

AFAIK, the committed code works as I explained above. It just cache the
precompiled code. The second run is faster because it only interpret the
precompiled code. In that way I told that we are caching just the compiled
part not the interpretation of it. If this is what we are talking about,
then it is already done.

I thought we spoke about a full cache (including the parameters) and in
that way the result can be stored in the cocoon cache. And this is not the
case. Or I don't saw it already working while developing and running the
same untouched URL 2 times. This is why I requested for a description of
the current status or how it works. Perhaps someone can write a doc about
it.

Also, the precompiled code is stored in a private static variable called
"cache". It does not interact with the JCS at all. I don't liked the
solution because old compiled code seeme to stay there forever and this is
a potential memory leak. But I am not sure. I need to see it closer to
tell if this is happenning and how to fix it.

Best Regards,

Antonio Gallardo.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to