Michael Neumann wrote:
Am Mon, 16 Feb 2009 11:45:45 +0100 schrieb Michael Neumann <[email protected]>:
*trimmed*
Looking at function getyn() posted by Bill Hacker I eventually understand what's wrong. Code - the universal language... So, really, the best thing that we can do is to introduce a --force-slave-pfs-creation switch and replace the getyn() call in cmd_mirror.c by a simple if (ForceSlavePfsCreation...). I like this more than the original approach (using ttys), as it is usable from within scripts.
Agree that. I still like the countdown as in cmd_pseudofs.c A Ctrl-c DOES work, and five second longer setup time is no show-stopper.
While we are working on this, we could replace all interactivity in hammer utilities with optional command line switches. So the strategy could be: first look if there is a switch specified, if not, fall back to /dev/tty, if this fails, assume NO. I do not like a command line switch "-f", which means anything (including force). It's too easy to mix it up with "-f" meaning "--file". Think about doing some admin work late after midnight, and your fingers go again faster than your brain; while a "rm -rf" on a Hammer FS would give you a second chance, a mixed up "hammer mirror-copy -f" would probably not :). I really would like to see a --force here (or a more specific one). Regards, Michael
Agree single-character options are impossible to keep straight. And scripts don't care much anyway.
How about these ones: -jfdi --just-fucking-do-it -bfbim --brute-force-and-bloody-ignorance-mode (my coding style, BTW. forth breeds that sort of um.. 'elegance') ;-) Bill
