On Thursday 01 July 2010 3:41:59 am Jim Talbut wrote: > Jira filed and patch submitted: > https://issues.apache.org/jira/browse/CXF-2865 > > The patch just permits both classes of exception, if there is a reason > to increase the timeout too just let me know and I'll do another > little patch.
Finally got around to applying this. Been a busy couple weeks. :-( Thanks! Dan > > Thanks > > Jim > > Quoting Jim Talbut <[email protected]>: > > On 30/06/2010 20:01, Daniel Kulp wrote: > >> OK. So I guess the fix is to update the test to increase the timeout to > >> 2 secs or so and also catch and allow the SocketTimeoutException. Want > >> to contribute a patch? (since you can test it on Windows and I cannot) > >> :- > > > > Why do both? > > Just checking for both exception types should work on all platforms: > > Index: > > src/test/java/org/apache/cxf/systest/dispatch/DispatchClientServerTest.ja > > va =================================================================== > > --- > > src/test/java/org/apache/cxf/systest/dispatch/DispatchClientServerTest.ja > > va (revision 959071) > > +++ > > src/test/java/org/apache/cxf/systest/dispatch/DispatchClientServerTest.ja > > va (working copy) > > @@ -162,8 +162,9 @@ > > > > fail("should not be a SOAPFaultException"); > > > > } catch (WebServiceException ex) { > > > > //expected > > > > - assertTrue(ex.getCause().getClass().getName(), > > - ex.getCause() instanceof > > java.net.ConnectException); + > > assertTrue(ex.getCause().getClass().getName(), > > + ex.getCause() instanceof > > java.net.ConnectException + || ex.getCause() > > instanceof > > java.net.SocketTimeoutException); > > > > } > > > > } > > > > Got to go for a bike ride now, I'll file a Jira and put the patch on > > that tomorrow morning. > > > > Jim > > ---------------------------------------------------------------- > This message was sent using IMP, the Internet Messaging Program. -- Daniel Kulp [email protected] http://dankulp.com/blog
