Nope.

getResourceAsStream(VERSION_BASE + "version.properties"

It loads that file as a filtered property, the version 
is attached to that files property via maven so the Version class
never has to be changed, it inherits from the maven build cycle.

/je

On Oct 15, 2010, at 7:01 PM, Robert J. Liguori wrote:

> 
> I'm looking at the Version class in org.apache.cxf.version.
> 
> I see three methods; getCompleteVersionString, getCurrentVersion and getName.
> 
> Wouldn't constant data members be more appropriate? 
> 
> For example:
> 
>  public static final String CURRENT_VERSION_NAME = "Apache CXF";
>  public static final String CURRENT_VERSION_NUMBER = "2.3.0";
>  public static final String CURRENT_VERSION_NAME _AND_NUMBER = "Apache CXF 
> 2.3.0";
> 
> Of course, an example reference would look like this:
> 
>  System.out.println("Version.CURRENT_VERSION_NAME");
> 
> Is this a good candidate for refactoring, or is there a specific reason for 
> the current design that I am missing?
> 
> Thanks.

Johan Edstrom

[email protected]

They that can give up essential liberty to purchase a little temporary safety, 
deserve neither liberty nor safety.

Benjamin Franklin, Historical Review of Pennsylvania, 1759





Reply via email to