Thanks for the pointer! That sounds fair. :-) Cheers, Woonsan
----- Original Message ----- > From: Sergey Beryozkin <[email protected]> > To: [email protected] > Cc: > Sent: Thursday, November 10, 2011 12:57 PM > Subject: Re: No warning on invalid _type parameter > > Hi Woonsan > On 09/11/11 15:15, Woonsan Ko wrote: >> Thanks again, Sergey! >> The issue is here: >> https://issues.apache.org/jira/browse/CXF-3897 >> >> > > Sorry, I started applying the patch and realized that queries like > _type=text/xml (in addition to _type=xml or if extensions are configured > then something like /bar.xml) are also supported, sorry I forgot to > realize it, please keep the contributions coming :-) > > thanks, Sergey > >> Cheers, >> >> Woonsan >> >> >> ----- Original Message ----- >>> From: Sergey Beryozkin<[email protected]> >>> To: [email protected] >>> Cc: >>> Sent: Tuesday, November 8, 2011 4:44 PM >>> Subject: Re: No warning on invalid _type parameter >>> >>> Hi >>> On 08/11/11 19:41, Woonsan Ko wrote: >>>> Hi, >>>> >>>> When an undefined _type parameter is used for JAX-RS requests > (e.g., >>> ?_type=foo), it doesn't give any warning logs. It just returns 406 > http >>> error code. >>> Enabling the fine logging should tell that no Accept header was > matched... >>>> It seems better to give a proper warning log in >>> o.a.cxf.jaxrs.impl.RequestPreprocessor#handleTypeQuery() method in that > case. >>>> Also, it currently uses the invalid type as Accept header even > though >>> there's no shortcut registered for the type parameter value. >>> >>> Agreed - it's a bug >>> >>>> Shall I create an JIRA issue with a patch for this? >>>> >>> Yes please, thanks >>> Sergey >>> >>>> Kind regards, >>>> >>>> Woonsan >>> >
