Yeah, sorry, it is a String vs QName comparison, I did not spot this branch was not even used in my local testing :-)

Thanks, Sergey



On 23/05/14 10:38, Aki Yoshida wrote:
A good catch.
The expression doesn't make sense as it will always evaluate to false.
It was probably intended to check the absence of the namespace part of
the values[i] to condition.
However, the result will be the same, as the second expression will
work for both cases.
Hence we can get rid of the condition.

thanks.
regards, aki


2014-05-23 1:14 GMT+02:00 Lou Marco <[email protected]>:

(Please forgive me if this is the wrong place for this)

Class QNamesMap has a private member QName[] values.
In the class' get method,  if it finds a QName whose NamespaceURI
matches the NamespaceURI of the passed argument but whose LocalPart
doesn't match, it evaluates a conditional expression whose Boolean is
"*".equals(values[i]).  But the elements of values[] are QNames, so
won't this always evaluate as FALSE?


Reply via email to