Hi
On 03/11/15 16:58, Jesse White wrote:
Hi Sergey,

On 11/03/2015 05:20 AM, Sergey Beryozkin wrote:
So let me introduce a property, not sure how to name though, may be instead of 
'preserve.local.ip.address' it should
be 'replace.loopback.address.with.localhost' - enabled by default which is what 
CXF does now and you'd set it to false
in jaxrs:properties.

That could work - we would also want to avoid replacing 0.0.0.0 though.

The call stack in question looks like:
     HttpUtils.toAbsoluteUri(URI, Message) line: 354
     UriInfoImpl.getBaseUri() line: 80
     UriInfoImpl.getAbsolutePathAsString() line: 218
     UriInfoImpl.getRequestUri() line: 127
     UriInfoImpl.getRequestUriBuilder() line: 136
     OnmsRestService.getRedirectUri(UriInfo, Object...) line: 266

Maybe we could avoid calling HttpUtils#toAbsoluteUri from 
UriInfoImpl#getBaseUri() when this new property is set?

That won;t save us much because we don't know yet if it is 127.0.0.1 - it can be coming from the network adapter after all.
http://git-wip-us.apache.org/repos/asf/cxf/commit/cb538a45

Hope it will help, as I said I'll need to investigate (refresh) why I did that replacement - there were some side-effects with 127.0.0., may be it is no loner the issue (whatever it was), so eventually we can make the replacement disabled by default

Cheers, Sergey
Best,
Jesse




--
Sergey Beryozkin

Talend Community Coders
http://coders.talend.com/

Reply via email to