We would probably need to dig deep into old containers as well to check whether this has some impact on them. The null-check doesn’t hurt imo. Probably we should just add a short explanation.
LieGrue, strub > Am 28.03.2015 um 13:23 schrieb [email protected]: > > While this is up for discussion, the cdi api here is pretty flawed? Not a big > issue but always bothered me... > > Skickat från min iPhone > >> 28 mar 2015 kl. 10:53 skrev Thomas Andraschko <[email protected]>: >> >> likely yes, but as i said: if we change it, we have to test it on every >> version/cdi container. >> >> 2015-03-26 18:39 GMT+01:00 Lars-Fredrik Smedberg <[email protected]>: >> >>> @Thomas and also remove the isActive call I guess? >>> On Mar 26, 2015 5:59 PM, "Thomas Andraschko" <[email protected]> >>> wrote: >>> >>>> Hi, >>>> >>>> i just added the null check to get sure. >>>> Removing the check + adding a unit test for it would be a better way. >>>>
