But, just to make it clear: You can simple fix it by removing the windowname in your window.open call and avoid having multiple ds:windowId in your view.
2017-12-21 13:01 GMT+01:00 Thomas Andraschko <[email protected]>: > probably this year, maybe january ;) > > 2017-12-20 17:13 GMT+01:00 Avinash Moram <[email protected]>: > >> Hi Thomas, >> >> I am following up of the email chain for 1.8.1. But do you know what would >> be the expected month of release, just so that I can inform my team? >> >> Thanks & Regards, >> Avinash >> >> On Tue, Dec 19, 2017 at 9:56 AM, Avinash Moram <[email protected]> >> wrote: >> >> > Thank you Thomas. Do you know if we have a release date for 1.8.1 or if >> > there is a place I can download the patch? >> > >> > And also, I think we forgot to updated the news section on the >> deltaspike >> > home page that the latest one is 1.8.0 and not 1.7.2 . >> > >> > Thanks & Regards, >> > Avinash >> > >> > On Tue, Dec 19, 2017 at 3:18 AM, Thomas Andraschko < >> > [email protected]> wrote: >> > >> >> second issue: you have multiple ds:windowId ;) >> >> >> >> improved both cases now with DELTASPIKE-1306 and DELTASPIKE-1305. >> >> >> >> 2017-12-19 9:36 GMT+01:00 Thomas Andraschko < >> [email protected] >> >> >: >> >> >> >> > The problem is that you use a windowname to open the view. >> >> > DeltaSpike uses the window.name to store the required windowId, so >> >> > therefore a window.name doesn't have any functionality when using DS >> >> > window handling. >> >> > >> >> > I can add a workaround so that a infinite loop won't occur but you >> can >> >> > simple fix it in your application. >> >> > >> >> > 2017-12-18 20:06 GMT+01:00 Avinash Moram <[email protected]>: >> >> > >> >> >> Hi Thomas, >> >> >> >> >> >> I have recreated it as a sample project and uploaded to github. >> >> >> https://github.com/avinashmoram/paris-ihw >> >> >> >> >> >> >> >> >> Thanks & Regards, >> >> >> Avinash >> >> >> >> >> >> On Fri, Dec 15, 2017 at 12:09 PM, Avinash Moram < >> [email protected]> >> >> >> wrote: >> >> >> >> >> >> > Hi Thomas, >> >> >> > >> >> >> > I will try to get one up on github this weekend. >> >> >> > >> >> >> > Thanks & Regards, >> >> >> > Avinash >> >> >> > >> >> >> > On Fri, Dec 15, 2017 at 12:07 PM, Thomas Andraschko < >> >> >> > [email protected]> wrote: >> >> >> > >> >> >> >> Can you replicate it in the jsf playground in our github repo? >> >> >> >> >> >> >> >> Am Freitag, 15. Dezember 2017 schrieb Avinash Moram : >> >> >> >> >> >> >> >> > Adding environment: deltaspike 1.7.2, EAP 7, Primefaces 6.1, >> >> >> Extensions >> >> >> >> > 6.1 | Mojarra 2.2.12-jbossorg-2 | JBOSS EAP 7.0.0 >> >> >> >> > >> >> >> >> > >> >> >> >> > Thanks & Regards, >> >> >> >> > Avinash >> >> >> >> > >> >> >> >> > On Fri, Dec 15, 2017 at 10:18 AM, Avinash Moram < >> >> [email protected] >> >> >> > >> >> >> >> > wrote: >> >> >> >> > >> >> >> >> >> Hi, >> >> >> >> >> >> >> >> >> >> looks like the images do not show up in the browser when using >> >> >> >> >> https://lists.apache.org/[email protected] >> rg >> >> >> >> >> >> >> >> >> >> *IE(as popup from window.open):* I see a url which has dswid >> >> empty >> >> >> >> >> URL Protocol Method Response >> >> >> >> >> /TCEQParis/faces/ui/cr/cr-re/cr-re-search.xhtml?dswid= >> HTTP >> >> >> GET >> >> >> >> >> 302 >> >> >> >> >> URL Protocol Method Response >> >> >> >> >> /TCEQParis/faces/ui/cr/cr-re/cr-re-search.xhtml?dswid=2192 >> >> HTTP >> >> >> >> >> GET 200 >> >> >> >> >> >> >> >> >> >> Because of that empty dswid= in the url IE goes into >> indefinite >> >> >> >> redirect >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> Thanks & Regards, >> >> >> >> >> Avinash >> >> >> >> >> >> >> >> >> >> On Wed, Dec 13, 2017 at 2:40 PM, Avinash Moram < >> >> [email protected] >> >> >> > >> >> >> >> >> wrote: >> >> >> >> >> >> >> >> >> >>> Hi, >> >> >> >> >>> >> >> >> >> >>> We have run into a problem similar to infinite redirects >> >> >> >> >>> <https://issues.apache.org/jira/browse/DELTASPIKE-754> when >> I >> >> >> open my >> >> >> >> >>> application through Window.open only on Internet Explorer >> (all >> >> >> >> versions). >> >> >> >> >>> >> >> >> >> >>> In the developer tools -> Network tab I see the following, >> the >> >> >> first >> >> >> >> >>> request has empty dswid in the url, then it redirects to get >> a >> >> new >> >> >> >> url with >> >> >> >> >>> dswid; and then IE goes into infinite redirects doing the >> same >> >> >> thing, >> >> >> >> first >> >> >> >> >>> request dswid is empty and second one not empty. >> >> >> >> >>> >> >> >> >> >>> IE(as popup from window.open): I see a url which has dswid >> empty >> >> >> >> >>> >> >> >> >> >>> [image: Inline image 2] >> >> >> >> >>> >> >> >> >> >>> IE(direct link, not opened as popup): I do not see an empty >> >> dswid >> >> >> >> >>> >> >> >> >> >>> [image: Inline image 4] >> >> >> >> >>> >> >> >> >> >>> I debugged the same in firefox, I still see the empty dswid, >> but >> >> >> >> firefox >> >> >> >> >>> doesn't go into infinite redirects. (same behavior with >> chrome) >> >> >> >> >>> Firefox: >> >> >> >> >>> [image: Inline image 3] >> >> >> >> >>> I looked at the code that 754 talks about the fix in >> >> >> >> >>> ClientWindowHelper#handleInitialRedirect >> >> >> >> >>> Inside ClientWindowHelper#constructRequestUrl we call >> >> >> >> >>> JsfUtils.addRequestParameters(externalContext, url, true); >> >> >> >> >>> >> >> >> >> >>> Do you think adding a condition not to add the parameter when >> >> the >> >> >> >> >>> parameter value is empty would solve the problem? >> >> >> >> >>> >> >> >> >> >>> And again I may be wrong, I am looking into this piece of >> code >> >> for >> >> >> the >> >> >> >> >>> first time. >> >> >> >> >>> >> >> >> >> >>> Thanks & Regards, >> >> >> >> >>> Avinash >> >> >> >> >>> >> >> >> >> >> >> >> >> >> >> >> >> >> >> > >> >> >> >> >> >> >> > >> >> >> > >> >> >> >> >> > >> >> > >> >> >> > >> > >> > >
