Hi, looks good to me. I will probably merge it this week.
Documentation is here: https://github.com/apache/deltaspike/tree/master/documentation Am So., 14. Juli 2019 um 16:35 Uhr schrieb Juri Berlanda < [email protected]>: > Hi all, > > as there was no further feedback, and because I was bored due to bad > weather, I decided to go ahead and implement the feature as proposed by > Thomas Andraschko. It can be found at > https://github.com/apache/deltaspike/pull/93 > > Btw.: Could someone please point me to where and how I can contribute to > the documentation? I would be happy to add the new feature myself. > > Cheers, > > Juri > > On 7/2/19 5:15 PM, Thomas Andraschko wrote: > > +1 for default backwards compatible and remove the flag in 2.0 > > > > Am Di., 2. Juli 2019 um 16:09 Uhr schrieb Juri Berlanda < > > [email protected]>: > > > >> Hi all, > >> > >> I recently stumbled over the auditing capabilities of DeltaSpike Data > >> module. I like them a lot, but I noticed that there is @CreatedOn and > >> @ModifiedOn for the timestamps, but only @ModifiedBy. I noticed, that > >> @ModifiedBy is set on creation (differently to @ModifiedOn), but it is > >> not preserved on updates (obviously). > >> > >> I would like to have @CreatedBy as well - analog to how the 2 timestamp > >> annotations work. That includes adding a setOnCreate property to > >> @ModifiedBy. > >> > >> I'm happy to work on a patch for this, but before that I'd like to put > >> up for discussion the following: > >> > >> * @ModifiedOn is (by default) not set on creation, @ModifiedBy is. So to > >> preserve backwards compatibility the 2 would have different default > >> behavior. > >> > >> Any thoughts on that? > >> > >> Cheers, > >> > >> Juri > >> > >> >
