Le 03/12/14 16:20, Colm O hEigeartaigh a écrit : > Thanks for the tips, I've made these changes locally. I have a further > question though - should we preserve the public method signatures in > ServerAnnotationProcessor that take a "startPort" parameter? This parameter > is only specified by the FrameworkRunner class, which always just passes > through a value of "1".
Curently, it's only called by the private createKdcServer() method. I suspect we made this method public in case we needed to expose the port creation. We don't use that atm. > > From my POV this parameter is now redundant as we start the transports on > either the port defined in the annotation, or else a random port (or the > same for multiple transports, if not specified). It might be redondant.
