W dniu 2016-01-27 14:48:05 u?ytkownik Thomas Monjalon <thomas.monjalon at 6wind.com> napisa?: > 2016-01-27 14:44, dawid_jurek: > > W dniu 2016-01-19 11:54:24 u?ytkownik dawid_jurek <dawid_jurek at vp.pl> > > napisa?: > > > > > > > > > W dniu 2016-01-19 11:19:55 u?ytkownik Thomas Monjalon <thomas.monjalon at > > > 6wind.com> napisa?: > > > > Hi > > > > > > > > 2016-01-19 10:45, dawid_jurek: > > > > > Hello DPDK developers, > > > > > I experienced issue when I ran tools/setup.sh and chose option [23]: > > > > > Bind Ethernet device to IGB UIO module. > > > > > Script Output: > > > > > File ".../dpdk/dpdk-2.2.0/tools/dpdk_nic_bind.py", line 113 > > > > > """ % locals() # replace items from local variables > > > > > ^ > > > > > SyntaxError: invalid syntax > > > > > It turned out that python 2.7 set as default in system was needed. > > > > > So I added python2 to every line with dpdk_nic_bind.py call in > > > > > tools/setup.sh and now it works fine. > > > > > But the question is: is it expected behaviour? Shouldn't it be fixed > > > > > by simple patch in way I did it? > > > > > > > > Yes a patch would be appreciated to make it python 3 friendly. > > > > Thanks > > > > > > > > > > OK. I will prepare patch for dpdk_nic_bind.py soon. > > > Regards, > > > Dawid > > > > > > > > > > Hello again, > > patch for this issue was prepared and tested on Arch (Python 3 is default) > > and Ubuntu (Python 2 is default) distros. > > In both cases syntax errors from dpdk_nic_bind.py disappeared and > > everything worked as expected. > > Patch is very simple and in most cases just adds extra brackets to print > > functions. > > Anyway please review this. > > It looks simple and good. > Please could you send it on dev at dpdk.org? > The procedure is described here: > http://dpdk.org/dev#send > and detailed here: > http://dpdk.org/doc/guides/contributing/patches.html > > Thanks >
Done. Available here: http://dpdk.org/ml/archives/dev/2016-January/032148.html Regards, Dawid
