The situation is similar to the OpenCL thorns: They are part of the Einstein Toolkit, part of the release, should be tested (where possible), and should be disabled by default in the thorn list since we assume most people won't be using them. That is inconvenient for testing, but convenient for the end users.
What we really need is a mechanism to easily select a subset of the thorns in the manifest. Simfactory has a mechanism for that, but that is per-machine and may not do what people want. I enable these thorns in my defs.local.ini where they make sense. -erik On Sun, May 12, 2013 at 4:48 AM, Ian Hinder <[email protected]> wrote: > > On 11 May 2013, at 21:48, Erik Schnetter <[email protected]> wrote: > > I test them regularly. They build fine on many systems (but not all). > > The reason we commented them out was that they take a long time to build, > while no standard ET thorn uses them. Please include them in the release. > > > Hi Erik, > > Do you mean to included them in the release, but commented-out in the > thornlist, or to uncomment them in the thornlist? > > If they are in the release, we need to test them as part of the usual > process. This will be awkward if they are commented out. Everyone will > have to remember to uncomment them before running the tests. The automated > test system also doesn't know that they should be tested. > > > -erik > > > On Sat, May 11, 2013 at 3:21 PM, Frank Loeffler <[email protected]> wrote: > >> On Sat, May 11, 2013 at 01:49:34PM -0400, Erik Schnetter wrote: >> > CactusElliptic/EllPETSc >> > CactusTest/TestAllTypes >> > ExternalLibraries/PETSc >> > TAT/TATPETSc >> >> Right. That's because they are commented out in the standard thornlist. >> Is this so because they don't build in a lot of places? With them being >> commented out they very likely don't receive much testing... >> >> Frank >> >> > > > -- > Erik Schnetter <[email protected]> > http://www.perimeterinstitute.ca/personal/eschnetter/ > _______________________________________________ > Users mailing list > [email protected] > http://lists.einsteintoolkit.org/mailman/listinfo/users > > > -- > Ian Hinder > http://numrel.aei.mpg.de/people/hinder > > -- Erik Schnetter <[email protected]> http://www.perimeterinstitute.ca/personal/eschnetter/
_______________________________________________ Users mailing list [email protected] http://lists.einsteintoolkit.org/mailman/listinfo/users
