On 11/5/18 12:33 PM, Roland Haas wrote:
Hello all,
Hydro_RNSID inherits from GRHydro, which goes against the usual policy that
initial data thorns depend only on HydroBase / ADMBase. Is there a plan to
fix this? Is a fix even difficult?
There's a pull request (8 months old) that fixes this here:
https://trac.einsteintoolkit.org/ticket/2128
Since I am the author I cannot review it, but anyone else can.
You can, however, nag people and ask repeatedly about reviews on the
mailing list.
--Steve
Note that this *could* induce a slight change in variables since
GRHydro's prim2con may not quite compute the conserved variables in the
very same way that Hydro_RNSID computed the primitives.
We *could* get perfect backwards compatibility by adding a parameter
and having Hydro_RNSID do what it does now if the parameter is set to
"yes" (which would be the default). One has to get the variable
pointers from VarDataPtr and probably should check for GRHydro being
active in ParamCheck.
Yours,
Roland
_______________________________________________
Users mailing list
[email protected]
http://lists.einsteintoolkit.org/mailman/listinfo/users
_______________________________________________
Users mailing list
[email protected]
http://lists.einsteintoolkit.org/mailman/listinfo/users
