Hello Bruno, thank you. I had not notice the pull request before (have to check if / how it is sending emails to me when pull requests are created).
I do see it on the web-interface (https://bitbucket.org/einsteintoolkit/einsteinanalysis/pull-requests/) though. Yours, Roland > Roland, > thanks for the info. We will follow these steps. Federico did also a pull > request recently of the new Hydro_Analysis thorn. > > Cheers, > Bruno > > > Il giorno gio 8 nov 2018 alle ore 16:33 Roland Haas <[email protected]> ha > scritto: > > > Hello Bruno, > > > > with trac allowing external accounts, you, Federica nad Nargess should > > be able to create a ticket with the enhancement for inclusion in the > > ET. Ideally your proposed patch would include a testsuite case (eg a > > resolution reduced version of the parfile you used to verify this > > against TOVSolver's results). > > > > The official rules for contributions are listed here: > > > > https://www.einsteintoolkit.org/contribute.html > > > > in particular > > > > > > * Components should be of sufficient quality to be used for peer-reviewed > > and > > published science. This includes a basic standard of software > > engineering, > > documentation of the software including algorithms and methods, > > tutorials and > > examples, and self-tests to demonstrate that the software works > > correctly. > > * To focus development and support, optimize resources, and provide best > > practises, the Einstein Toolkit components should be of current interest > > to > > the community. > > * All components must be distributed under an open source licence so that > > others can use these components without restrictions (except as mandated > > by > > scientific integrity), can modify and improve them as necessary, and can > > pass > > on these modifications to their collaborators as they see fit. > > > > though those are really geared towards bigger contributions like whole > > thorns and not small additions to functionality. > > > > Yours, > > Roland > > > > > Hi, > > > two collaborators of mine (Federico Cipolletta and Narges Shahamat, > > both > > > in cc to this email) have modified Hydro_Analysis in order to compute > > also > > > the rest mass. They are still cleaning the code, but maybe they can say a > > > few words about what they did and discuss how to commit these changes to > > > the Einstein Toolkit. > > > > > > Cheers, > > > Bruno > > > > > > > > > Il giorno dom 4 nov 2018 alle ore 19:46 Roland Haas <[email protected]> > > ha > > > scritto: > > > > > > > Hello all, > > > > > > > > for those in Europe, please keep in mind that the US has not yet > > > > changed over to standard time, ie 9:00am US central is 15:00 CET ie one > > > > hour earlier than usual. > > > > > > > > Yours, > > > > Roland > > > > > > > > > Hello, > > > > > > > > > > Please consider joining the weekly Einstein Toolkit phone call at > > > > > 9:00 am US central time on Mondays. For details on how to connect > > > > > and what agenda items are to be discussed, use the link below. > > > > > > > > > > > > https://docs.einsteintoolkit.org/et-docs/Main_Page#Weekly_Users_Call > > > > < > > > > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.einsteintoolkit.org%2Fet-docs%2FMain_Page&data=01%7C01%7Chelvi.witek%40kcl.ac.uk%7C8afba93ca1394f93112108d59c956bc3%7C8370cf1416f34c16b83c724071654356%7C0&sdata=NiaoD6IydyP1Y7iD5lgdJYyu47Zyv%2Byxy9ZJYCCfzLo%3D&reserved=0 > > > > > > > > > > > > > > > > > --Steve > > > > > > > > > > > > > > > > > > > > > -- > > > > My email is as private as my paper mail. I therefore support encrypting > > > > and signing email messages. Get my PGP key from http://pgp.mit.edu . > > > > _______________________________________________ > > > > Users mailing list > > > > [email protected] > > > > http://lists.einsteintoolkit.org/mailman/listinfo/users > > > > > > > > > > > > > > > > > > -- > > My email is as private as my paper mail. I therefore support encrypting > > and signing email messages. Get my PGP key from http://pgp.mit.edu . > > > > -- My email is as private as my paper mail. I therefore support encrypting and signing email messages. Get my PGP key from http://pgp.mit.edu .
pgpLAy3UrLKje.pgp
Description: OpenPGP digital signature
_______________________________________________ Users mailing list [email protected] http://lists.einsteintoolkit.org/mailman/listinfo/users
