Stuart McCulloch wrote:
2008/10/9 Marina Vatkina <[EMAIL PROTECTED]>
You are right - src/main/resources/META-INF/MANIFEST.MF was missing from my
ws. How does if affect anything? (And why 2.0.7 doesn't complain without
it?).
it shouldn't affect that particular project
It does - I added/removed the file several times.
because you're using
the bundle goal to generate the correct manifest - as for why
it doesn't complain on 2.0.7, that's a question for the Maven
team because the error is coming from the maven-jar-plugin
(presumably in 2.0.9 they changed some of the archiver code)
Thank you for your help.
Regards,
-marina
thanks,
-marina
Stuart McCulloch wrote:
2008/10/9 Marina Vatkina <[EMAIL PROTECTED]>
I'm building inside javax.ejb via 'mvn clean install'
yes, but what I'm saying is with the latest update of GlassFish
and that single line patch, when I do a 'mvn clean install' from
the project root with either 2.0.7 or 2.0.9 it works fine
if I then go into javax.ejb and do 'mvn clean install' it still works
so I'm thinking that you may have leftover changes either in the
build tree, or installed in your local repo that are affecting this
hence my suggestion to check (svn diff) and rebuild from the top
thanks,
-marina
Stuart McCulloch wrote:
2008/10/8 Marina Vatkina <[EMAIL PROTECTED]>
Stuart McCulloch wrote:
2008/10/8 Marina Vatkina <[EMAIL PROTECTED]>
Unfortunately I don't see any difference if I add <manifestLocation>
entry
:(.
hmm... this pom is from GlassFish isn't it? (it looks like it)
It is. I put the line inside <instructions>... but after I changed it
as
in
your example below, I got:
[INFO] [jar:jar]
[INFO]
------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO]
------------------------------------------------------------------------
[INFO] Error assembling JAR
Embedded error: Manifest file:
/export/v3/v3/ejb/javax.ejb/target/classes/META-INF/MANIFEST.MF does
not
exist.
Something else is not right?
do you have any other local changes and have you rebuilt from the root
folder?
when I grab the latest GlassFish code via svn and apply just the
following
patch
the full build completes successfully and the ejb bundle has the correct
manifest
regardless of whether I use Maven 2.0.7 or 2.0.9
(if you've previously modified and installed the parent poms you may
need
to
revert those changes and re-install them... otherwise Maven could pick
up
the
installed version in the local repo instead of the updated pom in the
build
tree)
Index: ejb/javax.ejb/pom.xml
===================================================================
--- ejb/javax.ejb/pom.xml (revision 23273)
+++ ejb/javax.ejb/pom.xml (working copy)
@@ -86,6 +86,7 @@
some other jar and other modules depend on this
artifact, we need to unpack.
-->
+
<manifestLocation>${pom.build.directory}</manifestLocation>
<unpackBundle>true</unpackBundle>
</configuration>
<executions>
thanks,
-marina
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
