Sahoo wrote:
Yes, the suggested fix definitely avoids the NPE, but that essentially masks the configuration problem. So, I am not sure if that's the right behavior. Instead, we should be checking if watchedDirectory exists or not. So, we should replace:

       this.watchedDirectory.mkdirs();

by

if(!this.watchedDirectory.mkdirs()) { throw new Exception("Faild to create " + watchedDirectory.getAbsolutePath());}

in DirectoryWatcher's constructor.

I suggest we separate this issue from 1228 to keep things clean.

Thanks,
Sahoo

I've created http://issues.apache.org/jira/browse/FELIX-1235
which contains a couple of suggestions.

Thank you
--
Guido Spadotto

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to