Thanks for the quick fix, Felix! Looks good here now. Jeremias Maerki
On 25.10.2012 11:22:27 Felix Meschberger wrote: > Hi Jeremias, > > Thanks for reporting. Will look into this today. > > In fact, I think calling MetaTypeService.getMetaTypeInformation on a fragment > should actually return null because a fragment augments the host and thus the > respective information should be returned on the host bundle. > > Regards > Felix > > Am 25.10.2012 um 10:57 schrieb Jeremias Maerki: > > > I've created https://issues.apache.org/jira/browse/FELIX-3734 which > > fixes the problem below. Incidentally, it also fixes my original > > problem: I can now create factory configurations in WebConsole 4.0.0. > > > > Do you still want a bundle with a ManagedServiceFactory to demonstrate > > the problem? But apparently, you've indirectly fixed the problem in > > MetaType already. It wasn't in the WebConsole 4.0.0. > > > > Thanks, > > Jeremias Maerki > > > > > > On 25.10.2012 10:41:04 Jeremias Maerki wrote: > >> Hi Felix, > >> > >> will do that shortly. In the meantime, I've compiled MetaType trunk and > >> checked if anything changes just from your changes. However, I ran into > >> an NPE calling up the Config page in the WebConsole. Apparently, > >> Bundle.getBundleContext() returns null for a fragment bundle. I have a > >> WebConsole branding fragment that caused this. > >> > >> I've locally changed MetaTypeInformationImpl slightly to verify that > >> it's the BundleContext that is causing an NPE when setting up the > >> MetaTypeProviderTracker: > >> > >> protected MetaTypeInformationImpl( Bundle bundle ) > >> { > >> this.bundle = bundle; > >> this.pids = new HashSet(); > >> this.factoryPids = new HashSet(); > >> this.metaTypeProviders = new HashMap(); > >> > >> BundleContext bundleContext = bundle.getBundleContext(); > >> if (bundleContext == null) { > >> throw new NullPointerException("BundleContext for bundle " + > >> bundle + " is null!"); > >> } > >> this.providerTacker = new MetaTypeProviderTracker( bundleContext, > >> this ); > >> this.providerTacker.open(); > >> } > >> > >> I assume it would simply be a matter of not creating a ServiceTracker > >> when BundleContext is null. > >> > >> I was positively surprised when I saw that it is now possible to expose > >> a MetaTypeProvider service for publishing metatype information. Opens > >> new possibilities. > >> > >> Thanks, > >> Jeremias Maerki > >> > >> > >> On 25.10.2012 09:23:22 Felix Meschberger wrote: > >>> Hi Jeremias > >>> > >>> I yesterday fixed an issue in the MetaType Service implementation with > >>> respect to properly handling factory PIDs and meta types. Can you > >>> report an issue with the following information: > >>> > >>> * version of web console and metatype service bundle used > >>> * a simple sample bundle exposing the issue > >>> > >>> Thank you very much. > >>> > >>> Regards > >>> Felix > >>> > >>> Am 24.10.2012 um 16:27 schrieb Jeremias Maerki: > >>> > >>>> I've recently installed WebConsole 4 and noticed that in the > >>>> Configuration tab, there are no longer any entries for factory > >>>> configurations. I can see that there is Java and JS code for factory > >>>> configurations but nothing shows up. Is there a bug or do I have wrong > >>>> expectations? > >>>> > >>>> Thanks, > >>>> Jeremias Maerki > >>>> > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: [email protected] > >>>> For additional commands, e-mail: [email protected] > >>>> > >>> > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: [email protected] > >>> For additional commands, e-mail: [email protected] > >>> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
