Wow, thats neat :-)
Didn't ever thought that theses small changes makes fsvs use clientcert
authentication.
I changed the path to /etc/subversion, see my attached patch. For our
scope imo it is better to have a global configuration.
Most peoples who use fsvs are admins so they would not have problems
with this.
Is it having the svn_config_get_config pointing to /etc/fsvs that
subversions configuration code would interfere with fsvs config?
Thanks for your effort!
Regards,
Gunnar
Philipp Marek wrote:
Could you test that and tell me what you think?
A simple checkout works for me - but I didn't test commit, diff etc.
If you say it's ok I'll commit that for the next release.
Thank you!
Regards,
Phil
Index: racallback.c
===================================================================
--- racallback.c (Revision 1847)
+++ racallback.c (Arbeitskopie)
@@ -48,6 +48,7 @@ svn_error_t *cb__init(apr_pool_t *pool)
cfg = apr_hash_get(cfg_hash, SVN_CONFIG_CATEGORY_CONFIG,
APR_HASH_KEY_STRING);
+
/* Set up Authentication stuff. */
STOPIF_SVNERR( svn_cmdline_setup_auth_baton,
(&cb__cb_table.auth_baton,
@@ -56,7 +57,7 @@ svn_error_t *cb__init(apr_pool_t *pool)
opt__get_string(OPT__AUTHOR) : NULL,
NULL, /* Password */
NULL, /* Config dir */
- 1, /* no_auth_cache */
+ 0, /* no_auth_cache */
cfg,
NULL, /* cancel function */
NULL, /* cancel baton */
Index: url.c
===================================================================
--- url.c (Revision 1847)
+++ url.c (Arbeitskopie)
@@ -12,6 +12,8 @@
#include <ctype.h>
#include <sys/select.h>
+#include <subversion-1/svn_config.h>
+
#include "url.h"
#include "waa.h"
#include "cache.h"
@@ -868,6 +870,12 @@ int url__open_session(svn_ra_session_t *
{
int status;
svn_error_t *status_svn;
+ apr_hash_t *cfg;
+
+//svn_client_create_context()
+ STOPIF_SVNERR( svn_config_get_config,
+ (&cfg, "/etc/subversion", global_pool));
+
status=0;
if (!current_url->pool)
@@ -877,13 +885,14 @@ int url__open_session(svn_ra_session_t *
"no pool");
}
+
/** Try svn_ra_reparent() */
if (!current_url->session)
{
STOPIF_SVNERR_EXTRA( svn_ra_open,
(& current_url->session, current_url->url,
&cb__cb_table, NULL, /* cbtable, cbbaton, */
- NULL, /* config hash */
+ cfg, /* config hash */
current_url->pool),
"Opening URL '%s' brought an error:", current_url->url);
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
