Thanks, Christian!
Here's another trivial patch that fixes access to uninitialized member.
Best regards,
Victor
On Mon, Apr 28, 2014 at 11:55 AM, Christian Schulte <cschu...@kth.se> wrote:
> Hi Victor,
>
>
>
> Thanks! I just committed the patch to the trunk.
>
>
>
> Cheers
>
> Christian
>
>
>
> --
>
> Christian Schulte, www.ict.kth.se/~cschulte/
>
>
>
> *From:* users-boun...@gecode.org [mailto:users-boun...@gecode.org] *On
> Behalf Of *victor.zverov...@gmail.com
> *Sent:* Monday, April 28, 2014 8:17 PM
> *To:* Guido Tack
> *Cc:* users@gecode.org
> *Subject:* Re: [gecode-users] Fwd: error when compiling Gecode with clang
> and -std=c++11
>
>
>
> Hi Guido,
>
>
>
> Thanks for committing the fix. There is one more, minor issue. I get a few
> warnings when using Gecode headers with a high warning level:
>
>
>
> gecode/set.hh:1278: warning: comma at end of enumerator list
>
> gecode/float.hh:1653: warning: comma at end of enumerator list
>
>
>
> Trailing commas in enums were only added in C++11 and, although most C++
> compilers support them as an extension, I think it would be nice if headers
> didn't rely on extensions. The attached patch fixes the warnings.
>
>
>
> Cheers,
>
> Victor
>
>
>
> On Thu, Apr 24, 2014 at 11:00 PM, Guido Tack <t...@gecode.org> wrote:
>
> Thanks Victor!
>
>
>
> I've added your fix to the svn trunk.
>
>
>
> Cheers,
>
> Guido
>
>
>
> --
>
> Guido Tack
>
> http://www.csse.monash.edu/~guidot/
>
>
>
>
>
>
>
> On 25 Apr 2014, at 10:33 am, victor.zverov...@gmail.com wrote:
>
>
>
> Hi,
>
>
>
> Sending this email again for it apparently hasn't come through last time.
>
>
>
> There is an error when compiling Gecode in debug mode with clang and
> -std=c++11 (I compile Gecode as a part of another project, so I don't use
> the default flags):
>
>
>
> gecode/flatzinc/flatzinc.cpp:280:34: error: comparison between pointer and
> integer ('SharedHandle::Object *' and 'int')
>
> (__builtin_expect(!(object() == false), 0) ? __assert_rtn(__func__,
> "gecode/flatzinc/flatzinc.cpp", 280, "object() == false") : (void)0);
>
> ~~~~~~~~ ^ ~~~~~
>
>
>
> This can be reproduced by compiling Gecode with the following commands:
>
>
>
> CXX=clang++ CXXFLAGS=-std=c++11 ./configure --enable-debug
>
> make
>
>
>
> The attached patch fixes the error.
>
>
>
> Best regards,
>
> Victor
>
>
>
>
>
>
>
>
> <fix-clang-c++11-error.patch>_______________________________________________
> Gecode users mailing list
> users@gecode.org
> https://www.gecode.org/mailman/listinfo/gecode-users
>
>
>
>
>
From effd160459a566e2fec06e121968bde3e96da921 Mon Sep 17 00:00:00 2001
From: Victor Zverovich <victor.zverov...@gmail.com>
Date: Mon, 28 Apr 2014 14:04:32 -0700
Subject: [PATCH] Fix access to uninitialized member.
---
test/set/rel.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/set/rel.cpp b/test/set/rel.cpp
index 2699049..3037e52 100644
--- a/test/set/rel.cpp
+++ b/test/set/rel.cpp
@@ -61,7 +61,7 @@ namespace Test { namespace Set {
/// Create and register test
RelBin(Gecode::SetRelType srt0, bool shared0)
: SetTest("Rel::Bin::"+str(srt0)+"::S"+(shared0 ? "1":"0"),
- shared ? 1 : 2,ds_33,true)
+ shared0 ? 1 : 2,ds_33,true)
, srt(srt0), shared(shared0){}
int minSymDiff(const SetAssignment& x) const {
int x1 = shared ? x[0] : x[1];
--
1.8.3.2
_______________________________________________
Gecode users mailing list
users@gecode.org
https://www.gecode.org/mailman/listinfo/gecode-users
