Looking at the ticket & patch, I think that code is always going to be kind of 
ugly when you allow people to mix strings and objects in configuration like 
that.
I think specifying either a pure string
ex: "BBOX"
or a pure object
ex: {type:"BBOX",ratio:1.25}

would be easier to deal with and would better match with the other 
configuration object conventions used in ExtJS, OL, & GeoExt

However people could mix the 2 different configuration specification types in 
the strategies array:
ex:
strategies : [ "Save", {type:"BBOX",ratio:1.25} ]

Thanks for getting this started.

Matt Priour
Kestrel Computer Consulting


From: Alexandre Dube 
Sent: Tuesday, March 22, 2011 3:02 PM
To: Matt Priour 
Cc: Eric Lemoine ; GeoEXT Users 
Subject: Re: [Users] WFSCapabilitiesReader - default layer strategies


Hi,

  An update about this thread.  I created a ticket : 
http://trac.geoext.org/ticket/412

  It contains a patch that fixes the issue.  I don't really like how I made it 
(it could have been better, I think) and it's missing test units.  Could 
someone give me a comment/hint about it, please ?

Kind regards,

Alexandre


On 11-02-15 09:27 AM, Matt Priour wrote: 
  +1 on the option to use the short strategy name string with an options object.
  We could implement this immediately in GeoExt when creating layers from the 
capabilities store and the layerOptions, if there is not equal support for that 
syntax directly in OL.

  I've also come across this issue and ended up solving it by listening to 
'add' event on the layer store and then modifying options on the layers 
accordingly. I would much prefer the ability to set the defaults in the 
layerOptions rather than having to modify them after creation.

  Matt Priour
  Kestrel Computer Consulting


  From: Eric Lemoine 
  Sent: Tuesday, February 15, 2011 7:51 AM
  To: Alexandre Dube 
  Cc: GeoEXT Users 
  Subject: Re: [Users] WFSCapabilitiesReader - default layer strategies


  > What if we started supporting this :
  > var layer = new OpenLayers.Layer.Vector("layer", {
  >    protocol: ...,
  >    strategies: ["OpenLayers.Strategy.BBOX"]
  > });
  >
  > and this too :
  > var layer = new OpenLayers.Layer.Vector("layer", {
  >    protocol: ...,
  >    strategies: [{"OpenLayers.Strategy.BBOX": {ratio: 1}}]
  > });

  That was my suggestion. And I think {"BBOX"} and {"BBOX": {ratio: 1}}
  could also be supported.



  -- 
  Eric Lemoine

  Camptocamp France SAS
  Savoie Technolac, BP 352
  73377 Le Bourget du Lac, Cedex

  Tel : 00 33 4 79 44 44 96
  Mail : [email protected]
  http://www.camptocamp.com
  _______________________________________________
  Users mailing list
  [email protected]
  http://www.geoext.org/cgi-bin/mailman/listinfo/users




-- 
Alexandre Dubé
Mapgears
www.mapgears.com
_______________________________________________
Users mailing list
[email protected]
http://www.geoext.org/cgi-bin/mailman/listinfo/users

Reply via email to