GitHub user alexmller closed a discussion: Would it be reasonable to split up 
*Get Filenames* into separate input and transform steps?

I would like to share my thoughts for your opinions on this.

It seems easy to misunderstand the behavior of *Get Filenames* (#4843):

- if "Is filename defined in a field?" is checked, it processes data from the 
stream and transforms it
- if not, it acts as an input, discarding incoming fields and generating its 
own rows

The same is for *Execute SQL script* and it's "Execute for each row" toggle. 
Fixing it by updating the docs feels right to me (#5734).

For *Get Filenames* however, the user dialog could be simplified and source 
code readability improved by separating both concerns into separate Steps. Of 
course introducing a breaking change.

Is there a preferred approach when it comes to breaking changes (avoid them at 
any cost or deal with them in a certain way)?

GitHub link: https://github.com/apache/hop/discussions/5737

----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: [email protected]

Reply via email to