Hi Dan, Great, thank you for that, it should work nicely.
Just to note though, I have since found out that WicketSignInPage is referenced directly by the PageAbstract class when creating the logout links. If it is desired to allow WicketSignInPage to be extended and customised then PageAbstract may need to be modified to somehow use PageClassRegistry.getPageClass instead. With your commit though we no longer need to do this. Many thanks for the excellent framework by the way. Cheers, Duncan On Thu, Jun 6, 2013 at 11:36 PM, Dan Haywood <[email protected]>wrote: > Hi Duncan, > Thanks for your interest in Apache Isis. > > So, two things. First, yes, WicketSignInPage should have been non-final > for precisely this kind of reason. One day, sometime in the future, it > might make sense for the codebase to be tightened up. But for where Isis > is right now in its adoption curve, my preference is to make it easy to > extend, even if only so devs can workaround gaps (like this one). > > Second, this requirement isn't a big deal, so I've gone ahead and > implemented it [1]. I've just pushed the change to our repo, so you can > pick up the change if you build Isis from source [2]. there's also a page > on our website explaining how to use the feature [3]. > > Any problems, let us know. > > Cheers > Dan > > [1] https://issues.apache.org/jira/browse/ISIS-424 > [2] http://isis.apache.org/contributors/building-isis.html > [3] > > http://isis.apache.org/components/viewers/wicket/suppressing-remember-me.html > > > > > On 6 June 2013 00:35, Duncan Aubrey <[email protected]> wrote: > > > Hello, > > > > I'm trying to determine how to remove the "remember me" feature from the > > Wicket viewer login page. By default the WicketSignInPage class enables > > this feature as it uses the single parameter parent constructor, which in > > turn uses the single parameter constructor of the SignInPanel class. > > > > One option would be to extend WicketSignInPage to use the SignInPanel(id, > > includeRememberMe) constructor that disables this feature, but > > WicketSignInPage is marked as final and cannot be extended. > > > > Another option is to extend SignInPage and do the same, but then the > > functionality in WicketSignInPage either has to be duplicated or is lost. > > > > Are there other options I'm missing? I looked for a configuration option > > but couldn't find it. I appreciate any help. > > > > Thanks, > > Duncan > > >
