Jeremy, really good stuff. Appreciate I didn't get round to answering all of your earlier questions, but happy with the direction you've gone.
Picking up on Martin's email, I've created a new branch ISIS-789 on origin and merged in your branch there. Obviously, I want to do a full review of the work first, plus run some regression tests, before merging into master. In particular, I need to wrap my head around the use of "org.datanucleus.enhancer.Persistable" instead of "javax.jdo.spi.PersistenceCapable". I suspect it's all fine and won't impact end users, but need to double check etc. But thanks a lot, again. I appreciate that there's a lot of work in that branch. Meantime, if you add any further commits, please add the "ISIS-789: " as a prefix to the commit messages. Cheers Dan On 3 January 2015 at 11:14, Martin Grigorov <[email protected]> wrote: > Great work, Jeremy! > > I haven't checked your changes yet but since there is a task about > upgrading to DataNucleus 4.x [1] I think it would be great if you send a > Pull Request [2]. > The Neo4j demo app could be used as a test in Isis to make sure we don't > break the integration by accident in the future. > > > 1. https://issues.apache.org/jira/browse/ISIS-789 > 2. https://help.github.com/articles/using-pull-requests/ > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Sat, Jan 3, 2015 at 12:00 AM, Branham, Jeremy [HR] < > [email protected]> wrote: > > > If you are interested in running Isis with Neo4j - > > Have a look at this branch that contains a sample application [neoapp] > > based on the 'simpleapp' example. > > https://github.com/jdbranham/isis/tree/DN_404 > > > > > > And a small extension that enables the embedded Neo4j services - > including > > the Neo4j browser, admin tools, and rest services. > > https://github.com/Sprint/isis-neo4j > > > > The Isis extension is small, and the one class could be copied and pasted > > into your application rather than building the jar. > > > > Hope this helps someone! > > > > > > Note - This branch uses DataNucleus 4.0.4 so there are currently many > > deviations from the master, though all tests are currently passing. > > > > > > Jeremy D. Branham > > Technology Architect > > Sprint University Performance Support > > Fort Worth, TX | Tel: **DOTNET > > Office: +1 (972) 405-2970| Mobile: +1 (817) 791-1627 > > > > > > > > ________________________________ > > > > This e-mail may contain Sprint proprietary information intended for the > > sole use of the recipient(s). Any use by others is prohibited. If you are > > not the intended recipient, please contact the sender and delete all > copies > > of the message. > > >
