Thanks Dan - I did make many changes from the earlier branch. I'm working through a few things to make it cleaner, and will review the Apache committing guidelines to save some review time.
I did notice an issue with HSQL not accepting the schema when creating new tables. I've tried it with and without quotes, but the only thing that has worked so far is removing the schema altogether. java.sql.SQLException: invalid schema name: simple in statement [CREATE TABLE "simple"."SimpleObject" ......... Jeremy D. Branham Tel: **DOTNET -----Original Message----- From: Dan Haywood [mailto:[email protected]] Sent: Thursday, March 19, 2015 3:19 AM To: users Subject: Re: Apache Isis 1.9.0 + DN 4.0.4 Hi Jeremy, Thanks for doing this... yes, if you create a PR, then I'll review and merge. (I do have a branch from your earlier work, but if you've tidied it up then so much the better). Cheers Dan On 19 March 2015 at 00:56, Branham, Jeremy [HR] <[email protected] > wrote: > I have merged the latest Apache Isis master with my fork [1] including > DataNucleus 4.0.4 > > There are some adjustments I can revert to make a pull request easier, > but should be ready to request it in the next couple of days if that is ok. > There are a lot of changes, but all tests are currently passing. > > > [1] https://github.com/jdbranham/isis > > > Jeremy D. Branham > Technology Architect > Sprint University Performance Support > > > ________________________________ > > This e-mail may contain Sprint proprietary information intended for > the sole use of the recipient(s). Any use by others is prohibited. If > you are not the intended recipient, please contact the sender and > delete all copies of the message. > ________________________________ This e-mail may contain Sprint proprietary information intended for the sole use of the recipient(s). Any use by others is prohibited. If you are not the intended recipient, please contact the sender and delete all copies of the message.
