Hi Dan,

On 05/05/2016 09:19 AM, Dan Haywood wrote:
Hi Erik,

I think that's an oversight... I can't thing of any particularly good
reason for this class not to use ComponentFactory.
Could you take a look at [1]? I expected some component factory method there. If it should be using a component factory there I will try to fix that. Otherwise, could you tell me why it is the way it is now?

There is actually a new SPI you could use to patch this... provide a new
implementation of GridSystemService (subclassing the default BS3 impl and
using @DomainService (menuOrder="1") to ensure your patched version is
found before the default impl).
That sounds good. I'll take a look at that.

Thanks,
Erik

[1] https://github.com/apache/isis/blob/master/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/layout/bs3/col/Col.java#L277

Reply via email to