Thanks a lot for the explanation and links, Dan. I think I understand this a bit better now (missed the fact that there needs to be an additional properties-file for the component-html file etc. -- complete wicket "noob" here). As soon as I am "geared up" for github-pull requests I hope I can contribute to fixing minor quirks like hardcoded strings and the like...
Cheers, Deacon On Tue, May 24, 2016 at 9:21 AM, Dan Haywood <d...@haywood-associates.co.uk> wrote: > Hmm, it would seem to be hard-coded [1]. > > Elsewhere in the Wicket UI we allow i18n, eg of the "OK" and "Cancel" > buttons [2], through a custom implementation of Wicket's Localizer SPI > [3]. So it ought to be possible to i18n the "Show All" similarly. > > If you want to tackle this and raise a PR, that'd be great. Otherwise I'll > see if I can implement it in the next couple of days. > > Thx > Dan > > > > [1] > > https://github.com/apache/isis/blob/rel/isis-1.12.1/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/collectioncontents/ajaxtable/IsisAjaxNavigationToolbar.html#L23 > [2] > > https://github.com/apache/isis/blob/rel/isis-1.12.1/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersFormPanel.java#L144 > [3] > > https://github.com/apache/isis/blob/rel/isis-1.12.1/core/viewer-wicket-impl/src/main/java/org/apache/isis/viewer/wicket/viewer/integration/wicket/LocalizerForIsis.java#L52 > [4] > > https://github.com/apache/isis/blob/rel/isis-1.12.1/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/collectioncontents/ajaxtable/IsisAjaxNavigationToolbar.java#L44 > > > On 23 May 2016 at 14:41, Deacon Frost <dfrost...@gmail.com> wrote: > > > Hi, > > > > I'm trying to wrap my head around the translation feature and I'd like to > > translate the "SHOW ALL"-label for the table paginator (ISIS-690). I > can't > > figure out the pot-address-string/msgid to translate this. Any hint how > to > > go about this? > > Thanks a lot! > > > > Cheers, > > > > D. > > >
