More tests is always good: we do have:

TestJsonLDReadWrite
TestRiotWriterGraph, TestRiotWriterDataset

and some other wiring tests.

There aren't specific tests of the JSONLD engine as far as I know - it assumes the dependency jsonld-java code does that.

        Andy


On 22/05/14 12:16, Rob Vesse wrote:
Andy

I hadn't realised we'd taken over provided the reader and writer pieces
ourselves

I already figured out a fix for this bug so I'll port it to our code base

Great


Btw I couldn't see any obvious JSON-LD tests in our code base, is this
something we would want to migrate from the old jsonld-java-jena module?

Cheers,

Rob

On 22/05/2014 11:20, "Andy Seaborne" <[email protected]> wrote:

On 22/05/14 10:23, Rob Vesse wrote:
Holger

The jsonld-java module is an external project not affiliated with Apache
Jena so any bugs with it should be reported to that project on GitHub

Note that our trunk uses that module as a dependency to add JSON-LD
support to Jena and that will be included in our next release so any
issues in that module that you can report and help get fixed will feed
into our use of the module in our next release

Regards,

Rob

Yes - Jena (dev) has JSON-LD as part of Jena directly and does not
require additional configuration by the user.

The reader code is at:

https://svn.apache.org/repos/asf/jena/trunk/jena-arq/src/main/java/org/apa
che/jena/riot/lang/JsonLDReader.java

Jena's dependency is on the com.github.jsonld-java:jsonld-java module
(the core JSON-LD engine) from that project and does not use the (old)
jsonld-java-jena artifact (integration/jena).

If there is a bug, could you provide a fix for the code in SVN please?

        Andy


On 22/05/2014 09:37, "Holger Knublauch" <[email protected]> wrote:

(I hope this is the right place to ask this question).

Looking at


https://github.com/jsonld-java/jsonld-java/blob/master/integration/jena/
sr
c/main/java/com/github/jsonldjava/jena/JsonLDReader.java

it seems that the current JSON-LD reader does not copy the prefix
definitions into the target Jena model, even though the writer is
correctly creating them.

Thanks
Holger











Reply via email to