On Thu, Jun 25, 2020 at 10:32 AM Andy Seaborne <[email protected]> wrote: > > > > On 25/06/2020 09:16, Martynas Jusevičius wrote: > > Andy, > > > > answers inline. > > > > On Thu, Jun 25, 2020 at 9:18 AM Andy Seaborne <[email protected]> wrote: > >> > >> How are you using it? > >> Indeed, what are you using it for? > >> > >> It's very old and has been replaced by StreamManager - with > >> compatibility (though that only applies for using jena-core on its own > >> ... which is not a good idea and can't be guaranteed to work for all > >> sorts of reasons). > >> > > > > We have multiple levels of subclasses of FileManager that override > > methods using Jersey client API and implement additional interfaces > > such as ModelGetter and URIResolver, UnparsedTextURIResolver: > > https://github.com/AtomGraph/Core/blob/master/src/main/java/com/atomgraph/core/util/jena/DataManager.java > > https://github.com/AtomGraph/Web-Client/blob/master/src/main/java/com/atomgraph/client/util/DataManager.java > > Too much code, out of context. > > What behaviour do they add? > Why aren't they using Locators? > Or GSP? >
The functionality for which we are using/extending FileManager is "given any URI - get us a Model" (and avoid an HTTP call by location-mapping and caching). That is what loadModel() does. If this would be about reading from HTTP only, I could roll our own implementation using Jersey client quite easily. But it's the integrated mapping and caching I want to reuse. The main behavior DataManager adds is URIResolver.resolve(String href, String base) used in the XML processing, which relies on loadModel(): https://github.com/AtomGraph/Web-Client/blob/master/src/main/java/com/atomgraph/client/util/DataManager.java#L123 How would GSP help here? Not sure about Locators either.
