Source verified, tests pass, quick start ok.

Binaries verified, tests on scala
https://github.com/stealthly/scala-kafka/pull/27 and go clients
https://github.com/stealthly/go_kafka_client/pull/55 passing.

If the release passes we should update the release notes to include the
change from KAFKA-1729 please.

+1 (binding)

~ Joe Stein

On Fri, Feb 20, 2015 at 9:08 PM, ted won <realtime...@gmail.com> wrote:

> +1
>
> On Friday, February 20, 2015, Guozhang Wang <wangg...@gmail.com> wrote:
>
> > +1 binding.
> >
> > Checked the md5, and quick start.
> >
> > Some minor comments:
> >
> > 1. The quickstart section would better include the building step after
> > download and before starting server.
> >
> > 2. There seems to be a bug in Gradle 1.1x with Java 8 causing the
> "gradle"
> > initialization to fail:
> >
> > ---------
> >
> > FAILURE: Build failed with an exception.
> >
> > * Where:
> > Build file '/home/guwang/Workspace/temp/kafka/build.gradle' line: 199
> >
> > * What went wrong:
> > A problem occurred evaluating root project 'kafka'.
> > > Could not create task of type 'ScalaDoc'.
> > --------------
> >
> > Downgrading Java to 1.7 resolve this issue.
> >
> > Guozhang
> >
> > On Wed, Feb 18, 2015 at 7:56 PM, Connie Yang <cybercon...@gmail.com
> > <javascript:;>> wrote:
> >
> > > +1
> > > On Feb 18, 2015 7:23 PM, "Matt Narrell" <matt.narr...@gmail.com
> > <javascript:;>> wrote:
> > >
> > > > +1
> > > >
> > > > > On Feb 18, 2015, at 7:56 PM, Jun Rao <j...@confluent.io
> > <javascript:;>> wrote:
> > > > >
> > > > > This is the first candidate for release of Apache Kafka 0.8.2.1.
> This
> > > > > only fixes one critical issue (KAFKA-1952) in 0.8.2.0.
> > > > >
> > > > > Release Notes for the 0.8.2.1 release
> > > > >
> > > >
> > >
> >
> https://people.apache.org/~junrao/kafka-0.8.2.1-candidate1/RELEASE_NOTES.html
> > > > >
> > > > > *** Please download, test and vote by Saturday, Feb 21, 7pm PT
> > > > >
> > > > > Kafka's KEYS file containing PGP keys we use to sign the release:
> > > > > http://kafka.apache.org/KEYS in addition to the md5, sha1
> > > > > and sha2 (SHA256) checksum.
> > > > >
> > > > > * Release artifacts to be voted upon (source and binary):
> > > > > https://people.apache.org/~junrao/kafka-0.8.2.1-candidate1/
> > > > >
> > > > > * Maven artifacts to be voted upon prior to release:
> > > > > https://repository.apache.org/content/groups/staging/
> > > > >
> > > > > * scala-doc
> > > > >
> https://people.apache.org/~junrao/kafka-0.8.2.1-candidate1/scaladoc/
> > > > >
> > > > > * java-doc
> > > > >
> https://people.apache.org/~junrao/kafka-0.8.2.1-candidate1/javadoc/
> > > > >
> > > > > * The tag to be voted upon (off the 0.8.2 branch) is the 0.8.2.1
> tag
> > > > >
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=kafka.git;a=tag;h=c1b4c58531343dce80232e0122d085fc687633f6
> > > > >
> > > > > /*******************************************
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Jun
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > -- Guozhang
> >
>

Reply via email to