Just checked the constraint, and the maximum is 900 for varchar before SQL Server 2016
On 2019/06/28 14:55:01, sendoh <unicorn.bana...@gmail.com> wrote: > > > On 2019/06/28 14:50:37, sendoh <unicorn.bana...@gmail.com> wrote: > > I encounter the same issue as > > https://github.com/confluentinc/kafka-connect-jdbc/issues/379 > > > > I think I could contribute to implement a custom > > `buildCreateTableStatement` in SqlServerDatabaseDialect that checks if > > primary key is a string, set it as VARCHAR(450) and logs it as warning. > > > > any suggestion? > > > > > or simply like the HANA implementation which only uses 1000 for VARCHAR > https://github.com/confluentinc/kafka-connect-jdbc/blob/bb352573e68698b14045e3fceed5d9b7632eb9e4/src/main/java/io/confluent/connect/jdbc/dialect/SapHanaDatabaseDialect.java#L102 >
