Hi Franck, Thank you for contributing to Apache Kafka!
1. Git is generally permissive of this, as long as there are no merge conflicts. If you have merge conflicts with `trunk`, you will need to resolve them before a committer can merge your changes, so rebasing on trunk before opening the PR is a good idea :) 2. Are you on an M1 mac, with a recent (>11) JDK? I've been experiencing some consistent failures recently [1] and haven't figured it out yet. You may also be getting a flaky failure: a test which is nondeterministic and sometimes fails. We are constantly trying to burn down the list of flaky tests [2], but there are still some around. As far as how this impacts the PR: You should find and resolve all of the deterministic failures that you introduce in the PR, and do your best to check whether you introduced any flakiness. You can look for tickets mentioning those failures, or ask a committer for more information. Hope this helps, Greg Harris [1] https://issues.apache.org/jira/browse/KAFKA-16701 [2] https://issues.apache.org/jira/browse/KAFKA-16701?jql=project%20%3D%20KAFKA%20AND%20labels%20%3D%20flaky-test On Tue, May 21, 2024 at 6:43 AM Franck <bou...@ulukai.net> wrote: > > Hello, > > It works like a charm. > > Few questions: > > 1. Now, I'm asking my self, I did the job describe in JIRA 16707 in a > fork/branch of the 3.7.0 of kafka, but reading the "Contributing > Code Change", I feeI should have done it on a branch from trunk of > my fork? (if so, I'll just do on my fork a new branch, rebase, and > re-run test for sure, I just want to from which point I should start > to PR correctly) > 2. when doing a "gradelew clean test" from a clean fork of the 3.7.0 > branch, I have a failure, so I'm asking my self how it will be > managed when I'll do the PR, do you know? > > Best regards > > On 21/05/2024 03:35, Matthias J. Sax wrote: > > Done. You should be all set :) > > > > > > -Matthias > > > > On 5/20/24 10:10 AM, bou...@ulukai.net wrote: > >> > >> Dear Apache Kafka Team, > >> > >> I hope to post in the right place: my name is Franck LEDAY, > >> under Apache-Jira ID "handfreezer". > >> > >> I opened an issue as Improvement KAFKA-16707 but I failed to > >> assigned it to me. > >> > >> May I ask to be added to the contributors list for Apache Kafka? > >> As I already did the job of improvement, and would like to be > >> assigned on to end my contribution. > >> > >> Thank you for considering my request. > >> Best regards, Franck.
