Begin forwarded message:
Date: Thu, 21 Nov 2002 11:19:25 +0300
From: Yury Mikhienko <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: Re: Bug in wsp_unit.c ?
Hi Vjacheslav!
>
> Seems that there is bug in wsp_unit.c
>
> static void main_thread(void *arg) {
> WAPEvent *e;
> WAPEvent *newevent;
>
> while (run_status == running && (e = list_consume(queue)) != NULL) {
> wap_event_assert(e);
> switch (e->type) {
> case T_DUnitdata_Ind:
> newevent = unpack_datagram(e);
> /* MUST BE INSERTED if (newevent != NULL) */
> dispatch_to_appl(newevent);
>
> unpack_datagram returns NULL
> (> 2002-11-12 09:21:45 [2] WARNING: WSP PDU with unknown type -1)
> and dispatch NULL to wap-appl.c
>
> So later in wap-appl.c we have (main_thread):
> while (run_status == running && (ind = list_consume(queue)) != NULL) {
> }
>
> and list_consume breaks the loop and
>
> > 2002-11-12 09:21:45 [6] DEBUG: Thread 6 (gw/wap-appl.c:main_thread) terminates.
>
> So any following requests will not be processed.
>
> I think we must insert check for NULL (see above, line /* MUST BE INSERTED)
>
> --
> Vjacheslav Chekushin mailto:[EMAIL PROTECTED]
> Latvian Mobile Phone Company http://www.lmt.lv
In Bug list?
--
Best regards,
Yury Mikhienko.
IT engineer, ZAO "Mobicom-Kavkaz"
--
Best regards,
Yury Mikhienko.
IT engineer, ZAO "Mobicom-Kavkaz"
