Re: CIMD2 DLRs BUG ?

[Mads N. Vestergaard - CoolSMS]

Hi Everybody, After looking a bit further into it, the first problem was prety clear. In gw/smsc/smsc_cimd2.c, the DLR was added like this: dlr_add(conn->name, ts, msg); But since DLRs is based on he connection ID, it should be like this: dlr_add(conn->id, ts, msg); 2nd, issue, iw when suing mysql for DLR storage, we supply a parameter for the destination, but never uses it: static struct dlr_entry* dlr_mysql_get(const Octstr *smsc, const Octstr *ts, const Octstr *dst) We have destionation there, but in the query:     sql = octstr_format("SELECT %s, %s, %s, %s, %s, %s FROM %s WHERE %s='%s' AND %s='%s';",                         octstr_get_cstr(fields->field_mask), octstr_get_cstr(fields->field_serv),                         octstr_get_cstr(fields->field_url), octstr_get_cstr(fields->field_src),                         octstr_get_cstr(fields->field_dst), octstr_get_cstr(fields->field_boxc),                         octstr_get_cstr(fields->table), octstr_get_cstr(fields->field_smsc),                         octstr_get_cstr(smsc), octstr_get_cstr(fields->field_ts), safe_ts); We only use the SMSCID and the TS. I'll try to make a few patches and submit it to the bug system. ...................................... Med venlig hilsen / Best Regards   Mads N. Vestergaard Teknisk ansvarlig / CTO CoolSMS www.coolsms.com Phone: +45 7026 1272 Fax: +45 7630 1046 Mobile: +45 4270 1272 This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. Mads N. Vestergaard - CoolSMS skrev: Hi There, With one of our new we start using CIMD. But as far as I can see there seems to be a bug in the DLR system. When a DLR is added, is sends this SQL string: INSERT INTO kannel_dlr (smsc, ts, `from`, `to`, service, url, mask, boxc, status) VALUES ('CIMD2:serverhost:port:username', '071229152034', 'CoolSMS', '4542701272', 'coolsmsc', '', '31', 'smsbox', '0'); So instead of the actual SMSCID, it adds the complete name for the connection. At the moment we have to give our CIMD connection a smsc name like this:  CIMD2:serverhost:port:username to be sure it selects for the correct DLR data, when the server sends back a DLR. Furthermore when receiving a DLR, it asks for the following: SELECT mask, service, url, `from`, `to`, boxc FROM kannel_dlr WHERE smsc='SMSC' AND ts='071228074132'; But since CIMD2 gives back a timestamp as the SMSCID, this will make it impossible to keep track of the DLRs if more is send in the same second. We have seen this our self. But in a CIMD dlr, the destination adress is also given, so it should be possible, to use this as a search parameter for the DLR aswell. All this is just my assumptions, haven't looked further into the source code, for CIMD, but I would be happy if anyone can confirm this is a bug or nor, if they have a working CIMD setup. Thanks in advance. -- ...................................... Med venlig hilsen / Best Regards   Mads N. Vestergaard Teknisk ansvarlig / CTO CoolSMS www.coolsms.com Phone: +45 7026 1272 Fax: +45 7630 1046 Mobile: +45 4270 1272 This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.