I disagree. We fail when entering a completely wrong (nonexistant) module name. We also should fail when the capitalization is wrong. We could allow *creating* a new module with different capitalization but that's another issue.
We cannot fix the getModel call unless we enforce a strict capitalization rule but we can fix the build script to allow only the existing module names, including capitalization. Michal, could you please file two bug reports, one for the getModel() call and one for the build script? There are separate issues (though certainly related). felix On Oct 26, 2009, at 10:38 AM, Simon Thulbourn wrote: > I'd have to agree with the other posts in this thread, that it's up > to the developer to to ensure that he or she is entering the correct > case/name into the build script. This stands for both of your points. > > Simon > > > On 26 Oct 2009, at 10:33, Michal Charemza wrote: > >> I just read over my original post, and realised I was getting the two >> issues confused: Modules and Models (ahem). But to try to clarify: >> >> On 26 Oct 2009, at 09:11, Felix Gilcher wrote: >>> this is indeed not an issue that needs fixing. If you choose to name >>> you module or action "admin" because you prefer lower-case letters >>> at >>> the start we let you do this. You'll need to refer to it as "admin" >>> with a lower case letter any where else in the code. Or do I miss >>> something and it fails even if you're using the same case >>> everywhere? >> >> It's the *lack* of failing when different capitalisation is used on >> OS >> X that's the issue, >> >> 1. For the capitalisation of *models*, the getModel method is case >> insensitive on OS X, but case sensitive on Linux. Therefore code that >> works on OS X will fail on Linux (as I discovered). If the incorrect >> capitalisation is used as an argument to getModel, I think it should >> fail in both cases. >> >> 2. For the capitalisation of *modules*, during the action-create >> script, using the incorrect capitalisation will not fail the script >> on >> OS X: it will appear to finish properly. However, the script uses >> this >> incorrect capitalisation in generated class names, and so then when >> PHP comes to use them, it will then fail later (as I discovered). I >> think the script should test for the correct capitalisation and fail >> if it's wrong. >> >> Michal. >> >> >> _______________________________________________ >> users mailing list >> [email protected] >> http://lists.agavi.org/mailman/listinfo/users >> > _______________________________________________ > users mailing list > [email protected] > http://lists.agavi.org/mailman/listinfo/users -- Felix Gilcher Bitextender GmbH Paul-Heyse-Str. 6 D-80336 München T: +49 89 57 08 15 16 F: +49 89 57 08 15 17 M: +49 172 840 88 28 [email protected] http://www.bitextender.com/ Amtsgericht München, HRB 174280 Geschäftsführer: David Zülke, Florian Clever _______________________________________________ users mailing list [email protected] http://lists.agavi.org/mailman/listinfo/users
