On Wed, Jan 29, 2025 at 11:48:56 -0000, Alex Serban wrote: > Hello, > > Thanks for the response and sorry for the big blob of text, I've actually > formatted the email with great detail, but I don't really know what happened > (I see it formatted well on the generated "attachment.html" on the forum > thread). > > I see the support for external snapshots was added for some time, indeed, > from version 9.9, by the end of 2023. But still, what I'm running on is > Libvirt `v10.5.0 (2024-07-01)`, and reverting to disk-only snapshots seems to > still not be supported, as I am getting the following error when trying to do > that: `Invalid target domain state 'disk-snapshot'. Refusing snapshot > reversion`. > > Going to the source code, I've tracked the part of the code raising this > error on `qemu_snapshot.c`, and I've also found the following patch: > https://lists.libvirt.org/archives/list/de...@lists.libvirt.org/thread/XQIJQAQFHCSM6HMXFVIM6VLYZUHXPYD7/, > which is not yet adopted even in the code of the project's `master` branch. > Applying this patch over v10.5 locally, made snapshot reversion on disk-only > snapshots work for me. > > Is the `qemu_snapshot: allow reverting to external disk only snapshot` patch > what you were referring to earlier? Is it safe to apply it like I did?
Oops, that patch fell through the cracks. I've ack'd it. Thanks for actually testing it. Obviously libvirt doesn't do patches to historical releases but it is likely that it will be applied to upstream as is and since you didn't get any trouble applying it to your version it should also work for you.
