By inspecting the code, I would suggest removing the old force_rtp_proxy along with the 's' flag (which is already deprecated). Keeping only rtpproxy_offer/rtpproxy_answer provides a cleaner design.
Comments? Regards, Ovidiu Sas On Tue, Sep 21, 2010 at 8:28 AM, Ovidiu Sas <[email protected]> wrote: > Hello Bogdan, > > You are right. I will shortly remove both checks leaving the force > and offer/answer invocation up to the script writer. > > > Regards, > Ovidiu Sas > > On Tue, Sep 21, 2010 at 5:32 AM, Bogdan-Andrei Iancu > <[email protected]> wrote: >> Hi Ovidiu, >> >> IMHO, it is a bit of none-sense to have the the offer and answer >> function any checks about the type of message or request name....This is >> a limitations, considering that you decide from script if it is an offer >> or answer, or in what scenario to use. >> >> Like: >> Daniel's case with UPDATE carrying SDP >> 200OK- ACK negotiation when you actually need to do offer in reply >> and answer in ACK request... >> >> Regards, >> Bogdan >> >> Ovidiu Sas wrote: >>> The nathelper code is checking if the request for which rtpproxy_offer >>> is invoked is INVITE. >>> Just add UPDATE along the INVITE check and it should work fine (see >>> the attached patch). >>> >>> >>> Regards, >>> Ovidiu Sas >>> >>> >>> On Fri, Sep 17, 2010 at 5:59 PM, Daniel Goepp <[email protected]> wrote: >>> >>>> Is there support for rtpproxy_offer on an UPDATE? >>>> >>>> In my route I have: >>>> >>>> if(has_sdp()) { >>>> xlog ("Setting rtpproxy_offer - Route 1"); >>>> if ( !rtpproxy_offer("rc","67.218.120.86") ) >>>> xlog ("==== rtpproxy problem - $rc"); >>>> else >>>> xlog ("==== rtpproxy ok"); >>>> } >>>> >>>> For an INVITE, this works fine, for an update, I get the problem. >>>> >>>> Thoughts? >>>> >>>> Thanks >>>> >>>> -dg >>>> >>>> _______________________________________________ >>>> Users mailing list >>>> [email protected] >>>> http://lists.opensips.org/cgi-bin/mailman/listinfo/users >>>> >>>> >>>> >>>> ------------------------------------------------------------------------ >>>> >>>> _______________________________________________ >>>> Users mailing list >>>> [email protected] >>>> http://lists.opensips.org/cgi-bin/mailman/listinfo/users >>>> >> >> >> -- >> Bogdan-Andrei Iancu >> OpenSIPS Bootcamp >> 15 - 19 November 2010, Edison, New Jersey, USA >> www.voice-system.ro >> >> >> _______________________________________________ >> Users mailing list >> [email protected] >> http://lists.opensips.org/cgi-bin/mailman/listinfo/users >> > _______________________________________________ Users mailing list [email protected] http://lists.opensips.org/cgi-bin/mailman/listinfo/users
