Hello Bogdan,

I implemented a similar test function that takes 6 parameters.
All values seems to be in the correct order in both fixup function and triggered function.

I attached a small patch that prints the value of the parameters right after the fixup function and then again before the function is called.

Please apply this patch and then check if the parameters values and order match between the fixup and triggered function?

Regards,
Razvan

On 04/06/2011 05:51 PM, rad bogdan wrote:
Hi Bogdan,

The "inversion" is only in the triggered function.
The arguments are passed correctly from left to right to the fixup function.

The triggered function is:

test_function(struct sip_msg *msg, char *arg1, char *arg2, char* arg3, char* arg4, char* arg5, char* arg6)
{
    str arg1_s  = {NULL, 0};

if(arg1 == NULL || fixup_get_svalue(msg, (gparam_p)arg1, &arg1_s) != 0)
    {
        LM_ERR("Invalid arg1 argument\n");
        return -1;
    }
.........
}

arg1_s.s has the value of arg6_s.s while arg6_s.s has the correct value.

Thanks,
Bogdan

--- On *Wed, 4/6/11, Bogdan-Andrei Iancu /<[email protected]>/* wrote:


    From: Bogdan-Andrei Iancu <[email protected]>
    Subject: Re: [OpenSIPS-Users] function with 6 parameters
    To: "OpenSIPS users mailling list" <[email protected]>
    Cc: "rad bogdan" <[email protected]>
    Date: Wednesday, April 6, 2011, 5:15 PM

    Hi Bogdan,

    This "inversion" is visible in the fixup function or is the
    triggered function ?

    Regards,
    Bogdan

    On 04/06/2011 02:44 PM, rad bogdan wrote:
    Hi everyone,

    I implemented an OpenSIPS custom module that communicates with an
    external application. From the routing script I call a function
    with 6 parameters:

    test_function('$fU', '$tU', '$ci', '$avp(s:name1)',
    '$avp(s:name2)', '$var(name3)')

    The problem is that when the corresponding function is called in
    C, the first parameter gets the value of the last one.

    This doesn't happen when the function is made to take 5 parameters.

    The fixup function that I use is this:

    static int pvn_fixup_spve_spve_6(void** param, int param_no)
    {
        if (!(param_no >= 1 && param_no <= 6))
        {
            LM_ERR("invalid parameter number %d\n", param_no);
            return E_UNSPEC;
        }

        return fixup_spve(param);
    }

    Is there something wrong with it or the problem is elsewhere ?

    Thanks,
    Bogdan


    _______________________________________________
    Users mailing list
    [email protected]  </mc/[email protected]>
    http://lists.opensips.org/cgi-bin/mailman/listinfo/users


-- Bogdan-Andrei Iancu
    OpenSIPS eBootcamp - 2nd of May 2011
    OpenSIPS solutions and "know-how"


_______________________________________________
Users mailing list
[email protected]
http://lists.opensips.org/cgi-bin/mailman/listinfo/users
Index: action.c
===================================================================
--- action.c	(revision 7863)
+++ action.c	(working copy)
@@ -1192,6 +1192,11 @@
 			break;
 		case MODULE_T:
 			if ( (a->elem[0].type==CMD_ST) && a->elem[0].u.data ) {
+				LM_INFO("called %s(%p, %p, %p, %p, %p, %p)\n", 
+						((cmd_export_t*)a->elem[0].u.data)->name,
+						a->elem[1].u.data, a->elem[2].u.data,
+						a->elem[3].u.data, a->elem[4].u.data,
+						a->elem[5].u.data, a->elem[6].u.data);
 				ret=((cmd_export_t*)(a->elem[0].u.data))->function(msg,
 						 (char*)a->elem[1].u.data, (char*)a->elem[2].u.data,
 						 (char*)a->elem[3].u.data, (char*)a->elem[4].u.data,
Index: route.c
===================================================================
--- route.c	(revision 7863)
+++ route.c	(working copy)
@@ -399,6 +399,8 @@
 					else {
 						for (i=1; i<=cmd->param_no; i++) {
 							ret=cmd->fixup(&t->elem[i].u.data, i);
+							LM_INFO("fixed %s[%d] %p\n", cmd->name, i,
+									t->elem[i].u.data);
 							t->elem[i].type=MODFIXUP_ST;
 							if (ret<0) goto error;
 						}
_______________________________________________
Users mailing list
[email protected]
http://lists.opensips.org/cgi-bin/mailman/listinfo/users

Reply via email to