Hi Duane,

as sometime you may generate in-dialog requests, having a default Cseq to minimum is not a good idea :). On the other hand it is a risky gambling here.

But as you said :
1) RFC does not enforce a start value for the cseq (neither the increment value) 2) if you do not want opensips to use default, simply push your own cseq via the "headers" param.

Best regards,
Bogdan

Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com


On 08/16/2012 06:56 AM, Duane Larson wrote:

I'm not sure if this is an issue or not.

When t_uac_dlg is not passed a "CSeq" header it goes ahead and sets the "CSeq" value to 10. So if I send a REFER message you will see

REFER sip:[email protected]:3072 <http://sip:[email protected]:3072> SIP/2.0
Max-Forwards: 10
Record-Route: <sip:192.168.88.1;r2=on;lr>
Via: SIP/2.0/UDP 192.168.88.1;branch=z9hG4bKa4af.4c9709a4.0
To: sip:[email protected] <mailto:sip%[email protected]>
From: <sip:[email protected] <mailto:sip%[email protected]>>;tag=13450882214706
CSeq: 10 REFER
Call-ID: 13450882214706
Content-Length: 0
User-Agent: OpenSIPS (1.8.0-dev0-tls (x86_64/linux))
Contact: <sip:x@x:5060>
Refer-To: sip:[email protected] <mailto:sip%[email protected]>

For some reason my Snom phone isn't liking this and I've informed them about this and hopefully they see it as a bug on their part.


The reason I am emailing is because I was wondering if there is an error in the mi.c code on the follow lines
513  /* Fill in CSeq */
514  if (cseq!=-1)
515  dlg.loc_seq.value = cseq;
516  else
517  dlg.loc_seq.value = *DEFAULT_CSEQ*;
518  dlg.loc_seq.is_set = 1;
I am not sure what *DEFAULT_CSEQ is *refering to but if I change this to be the value of "1" then the issue when "CSeq" isn't defined in t_uac_dlg generating a 10 as the value goes away. Also I tested to be sure that when a value IS sent to t_uac_dlg that value is used instead of "1" and everything still worked.
Shouldn't it be something like
513 /* Fill in CSeq */
514 if (cseq!=-1)
515 dlg.loc_seq.value = cseq;
516 else
517 dlg.loc_seq.value = *1*;
518 dlg.loc_seq.is_set = 1;
I wasn't sure if this was an error in the code or if there is a reason behind it being *DEFAULT_CSEQ*


_______________________________________________
Users mailing list
[email protected]
http://lists.opensips.org/cgi-bin/mailman/listinfo/users
_______________________________________________
Users mailing list
[email protected]
http://lists.opensips.org/cgi-bin/mailman/listinfo/users

Reply via email to