Hi Giuseppe,
Try the attached patch and let me know if it does the trick for you.
Regards,
Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com
On 21.08.2014 12:30, Giuseppe Cardone wrote:
Hi Bogdan,
yes I do.
I've copied the extract of the log with the processing of the 180
Ringing, just in case you need any more
info.
Kind regards,
Giuseppe
<stripped>
------------------------------------------------------------------------
*Da: *"Bogdan-Andrei Iancu" <[email protected]>
*A: *"OpenSIPS users mailling list" <[email protected]>,
"[email protected] >> Giuseppe Cardone" <[email protected]>
*Inviato: *Giovedì, 21 agosto 2014 10:35:17
*Oggetto: *Re: [OpenSIPS-Users] b2b module issue with PRACK on
multiple provisional responses
Hi Giuseppe,
Do you see in your logs any entries for "b2b_tm_cback" when the
180 is processed ?
Regards,
Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com
On 09.08.2014 19:39, Giuseppe Cardone wrote:
Hi,
I'm trying out the b2b module on opensips and have encountered
an issue regarding PRACK.
In particular I have a scenario where the called number
replies with a 183 session progress (Require: 100rel and RSeq:
1) and then a few seconds later with a 180 Ringing (Require:
100rel and RSeq: 2).
What happens is that opensips correctly replies with a PRACK
to the 183 response but then doesn't do the same when it
receives the 180 provisional response.
Excerpts from the logs show this happening when the 183
message is received:
Aug 9 17:31:14 [2528] DBG:b2b_entities:b2b_tm_cback: Found
require hdr
Aug 9 17:31:14 [2528] DBG:b2b_entities:b2b_tm_cback: Found
100rel header
Aug 9 17:31:14 [2528] DBG:b2b_entities:b2b_send_req: start type=1
but when the 180 response arrives, there are no similar entries.
It is my understanding that from a SIP signalling point of
view the b2b module should reply with a PRACK to the 180
response too or am I missing something ?
Any ideas as to why this may be happening or could it be a bug ?
Many thanks,
Giuseppe
_______________________________________________
Users mailing list
[email protected]
http://lists.opensips.org/cgi-bin/mailman/listinfo/users
diff --git a/modules/b2b_entities/dlg.c b/modules/b2b_entities/dlg.c
index 67e4858..ce3927d 100644
--- a/modules/b2b_entities/dlg.c
+++ b/modules/b2b_entities/dlg.c
@@ -2526,16 +2526,15 @@ dummy_reply:
if(leg)
{
LM_DBG("Found existing leg - Nothing to update\n");
- goto done;
- }
-
- leg = b2b_add_leg(dlg, msg, &to_tag);
- if(leg == NULL)
- {
- LM_ERR("Failed to add dialog leg\n");
- goto error;
+ } else {
+ leg = b2b_add_leg(dlg, msg, &to_tag);
+ if(leg == NULL)
+ {
+ LM_ERR("Failed to add dialog leg\n");
+ goto error;
+ }
+ UPDATE_DBFLAG(dlg);
}
- UPDATE_DBFLAG(dlg);
/* PRACK handling */
/* if the provisional reply contains a
* Require: 100rel header -> send PRACK */
_______________________________________________
Users mailing list
[email protected]
http://lists.opensips.org/cgi-bin/mailman/listinfo/users
