Hi Ben
Thanks for more testing :). I managed to identify the bug for this crash
- even if the regexp is bogus, opensips should not crash. See
https://github.com/OpenSIPS/opensips/commit/37eab9a8c2dd19a17f2617057ca2014e9ffee263
Regards,
Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com
OpenSIPS Summit 2018
http://www.opensips.org/events/Summit-2018Amsterdam
On 02/27/2018 09:47 PM, Ben Newlin wrote:
Bogdan,
I found this previous thread that has this error:
http://lists.opensips.org/pipermail/users/2016-October/035635.html
The fix suggested there worked. When I removed the quotes around the
regexp used in re.subst the crash did not occur.
Ben Newlin
*From: *Ben Newlin <[email protected]>
*Date: *Tuesday, February 27, 2018 at 2:20 PM
*To: *Bogdan-Andrei Iancu <[email protected]>, OpenSIPS users
mailling list <[email protected]>
*Subject: *Re: [OpenSIPS-Users] OpenSIPS crashing on 200 OK
Bogdan,
I just tested it and that crash is no longer occurring. However I am
now seeing a different crash, but it seems to still be related to regexp.
Feb 27 19:07:17 [369] ERROR:core:subst_parser: string too short
Feb 27 19:07:17 [369] ERROR:core:tr_eval_re: Can't compile regexp
Feb 27 19:07:17 [369] WARNING:core:do_assign: no value in right
expression at /opensips/control.cfg:1952
Feb 27 19:07:17 [361] INFO:core:handle_sigs: child process 369 exited
by a signal 11
Feb 27 19:07:17 [361] INFO:core:handle_sigs: core was generated
Feb 27 19:07:17 [361] INFO:core:handle_sigs: terminating due to SIGCHLD
The do_assign error makes it seem like there may be something wrong in
my script, but I can’t see what it is. And I’m not sure what the
“string too short” error is either or why the regexp could not be
compiled. It looks valid to me.
Backtrace: https://pastebin.com/Fk2BRnsg
Ben Newlin
*From: *Bogdan-Andrei Iancu <[email protected]>
*Date: *Tuesday, February 27, 2018 at 12:55 PM
*To: *OpenSIPS users mailling list <[email protected]>, Ben
Newlin <[email protected]>
*Subject: *Re: [OpenSIPS-Users] OpenSIPS crashing on 200 OK
Hi Ben,
I just committed the fix for this - could you update from GIT and give
it a new try ?
Thanks and regards,
Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com
OpenSIPS Summit 2018
http://www.opensips.org/events/Summit-2018Amsterdam
On 02/27/2018 06:19 PM, Bogdan-Andrei Iancu wrote:
Thanks Ben for the support in investigating this. The bug was
identified and confirm, let me work on a fix right now. I will
shortly ping you for testing ;)
Regards,
Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com
OpenSIPS Summit 2018
http://www.opensips.org/events/Summit-2018Amsterdam
On 02/27/2018 12:12 AM, Bogdan-Andrei Iancu wrote:
OK, to be more precise, the crash is around an "If" statement
where you have in the condition an REGEXP test (=~) with a
left operand translated into "downstream" (maybe a $DLG_dir ??).
Does it sound familiar to you :) ?
Regards,
Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com
OpenSIPS Summit 2018
http://www.opensips.org/events/Summit-2018Amsterdam
On 02/26/2018 11:32 PM, Ben Newlin wrote:
Yes, that is from that exact file, line 435. It’s just a
return statement. I can send you the file off-list if
you’d like.
I do use the $DLG_dir in my script in a few places, but
the only one this crash would have hit is in some logging.
Ben Newlin
_______________________________________________
Users mailing list
[email protected]
http://lists.opensips.org/cgi-bin/mailman/listinfo/users
